Re: [Qemu-devel] [PATCH for-2.12] nbd: Fix 32-bit compilation on BLOCK_STATUS

2018-03-28 Thread Vladimir Sementsov-Ogievskiy
28.03.2018 00:05, Eric Blake wrote: iotests 123 and 209 fail on 32-bit platforms. The culprit: sizeof(extent) is wrong; we want sizeof(*extent). But since the struct is 8 bytes, it happened to work on 64-bit platforms where the pointer is also 8 bytes (nasty). Fixes: 78a33ab58 Reported-by: Max

Re: [Qemu-devel] [PATCH for-2.12] nbd: Fix 32-bit compilation on BLOCK_STATUS

2018-03-27 Thread Paolo Bonzini
On 27/03/2018 23:05, Eric Blake wrote: > iotests 123 and 209 fail on 32-bit platforms. The culprit: > sizeof(extent) is wrong; we want sizeof(*extent). But since > the struct is 8 bytes, it happened to work on 64-bit platforms > where the pointer is also 8 bytes (nasty). > > Fixes: 78a33ab58 > R

[Qemu-devel] [PATCH for-2.12] nbd: Fix 32-bit compilation on BLOCK_STATUS

2018-03-27 Thread Eric Blake
iotests 123 and 209 fail on 32-bit platforms. The culprit: sizeof(extent) is wrong; we want sizeof(*extent). But since the struct is 8 bytes, it happened to work on 64-bit platforms where the pointer is also 8 bytes (nasty). Fixes: 78a33ab58 Reported-by: Max Reitz Signed-off-by: Eric Blake ---