Re: [Qemu-devel] [PATCH for-2.10 07/23] pc: add node-id property to CPU

2017-05-02 Thread Igor Mammedov
On Tue, 2 May 2017 14:27:12 +1000 David Gibson wrote: > On Thu, Apr 27, 2017 at 01:32:25PM -0300, Eduardo Habkost wrote: > > On Thu, Apr 27, 2017 at 03:14:06PM +0200, Igor Mammedov wrote: > > > On Wed, 26 Apr 2017 09:21:38 -0300 > > > Eduardo Habkost wrote: > > > > > > adding Peter to CC list

Re: [Qemu-devel] [PATCH for-2.10 07/23] pc: add node-id property to CPU

2017-05-01 Thread David Gibson
On Thu, Apr 27, 2017 at 01:32:25PM -0300, Eduardo Habkost wrote: > On Thu, Apr 27, 2017 at 03:14:06PM +0200, Igor Mammedov wrote: > > On Wed, 26 Apr 2017 09:21:38 -0300 > > Eduardo Habkost wrote: > > > > adding Peter to CC list > > > > [...] > > > > > On Wed, Apr 19, 2017 at 01:14:58PM +0200, I

Re: [Qemu-devel] [PATCH for-2.10 07/23] pc: add node-id property to CPU

2017-04-27 Thread Eduardo Habkost
On Thu, Apr 27, 2017 at 07:25:23PM +0200, Igor Mammedov wrote: [...] > > > # > > > # A discriminated record of NUMA options. (for OptsVisitor) > > > # > > > +# For 'cpu' type as arguments use a set of cpu properties returned > > > +# by query-hotpluggable-cpus[].props, where node-id could be use

Re: [Qemu-devel] [PATCH for-2.10 07/23] pc: add node-id property to CPU

2017-04-27 Thread Igor Mammedov
On Thu, 27 Apr 2017 13:32:25 -0300 Eduardo Habkost wrote: > On Thu, Apr 27, 2017 at 03:14:06PM +0200, Igor Mammedov wrote: > > On Wed, 26 Apr 2017 09:21:38 -0300 > > Eduardo Habkost wrote: > > > > adding Peter to CC list > > > > [...] > > > > > On Wed, Apr 19, 2017 at 01:14:58PM +0200, Igor M

Re: [Qemu-devel] [PATCH for-2.10 07/23] pc: add node-id property to CPU

2017-04-27 Thread Eduardo Habkost
On Thu, Apr 27, 2017 at 03:14:06PM +0200, Igor Mammedov wrote: > On Wed, 26 Apr 2017 09:21:38 -0300 > Eduardo Habkost wrote: > > adding Peter to CC list > > [...] > > > On Wed, Apr 19, 2017 at 01:14:58PM +0200, Igor Mammedov wrote: > > > On Wed, 12 Apr 2017 18:02:39 -0300 > > > Eduardo Habkost

Re: [Qemu-devel] [PATCH for-2.10 07/23] pc: add node-id property to CPU

2017-04-27 Thread Igor Mammedov
On Wed, 26 Apr 2017 09:21:38 -0300 Eduardo Habkost wrote: adding Peter to CC list [...] > On Wed, Apr 19, 2017 at 01:14:58PM +0200, Igor Mammedov wrote: > > On Wed, 12 Apr 2017 18:02:39 -0300 > > Eduardo Habkost wrote: > > > > > On Wed, Mar 22, 2017 at 02:32:32PM +0100, Igor Mammedov wrote:

Re: [Qemu-devel] [PATCH for-2.10 07/23] pc: add node-id property to CPU

2017-04-26 Thread Eduardo Habkost
(Sorry for taking so long to continue the discussion. I thought I was convinced setting node-id on HotpluggableCPU.props was required, but after thinking more about it, it looks like it's still not required.) On Wed, Apr 19, 2017 at 01:14:58PM +0200, Igor Mammedov wrote: > On Wed, 12 Apr 2017 18:

Re: [Qemu-devel] [PATCH for-2.10 07/23] pc: add node-id property to CPU

2017-04-19 Thread Igor Mammedov
On Wed, 12 Apr 2017 18:02:39 -0300 Eduardo Habkost wrote: > On Wed, Mar 22, 2017 at 02:32:32PM +0100, Igor Mammedov wrote: > > it will allow switching from cpu_index to property based > > numa mapping in follow up patches. > > I am not sure I understand all the consequences of this, so I > wil

Re: [Qemu-devel] [PATCH for-2.10 07/23] pc: add node-id property to CPU

2017-04-12 Thread Eduardo Habkost
On Wed, Mar 22, 2017 at 02:32:32PM +0100, Igor Mammedov wrote: > it will allow switching from cpu_index to property based > numa mapping in follow up patches. I am not sure I understand all the consequences of this, so I will give it a try: "node-id" is an existing field in CpuInstanceProperties.

[Qemu-devel] [PATCH for-2.10 07/23] pc: add node-id property to CPU

2017-03-22 Thread Igor Mammedov
it will allow switching from cpu_index to property based numa mapping in follow up patches. Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 17 + target/i386/cpu.c | 1 + 2 files changed, 18 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 7031100..873bbfa 1006