Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 12:07, Cornelia Huck wrote: > On Tue, 15 Aug 2017 11:00:51 +0100 > Peter Maydell wrote: > >> On 14 August 2017 at 21:44, Eric Farman wrote: >> > How often does one really do a "make clean" ? Rather infrequently, >> > as I only stumbled on this today. >> >> FWIW, one of my s

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Cornelia Huck
On Tue, 15 Aug 2017 11:00:51 +0100 Peter Maydell wrote: > On 14 August 2017 at 21:44, Eric Farman wrote: > > How often does one really do a "make clean" ? Rather infrequently, > > as I only stumbled on this today. > > FWIW, one of my standard pre-merge build tests does a > "make clean" and t

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Eric Farman
On 08/15/2017 04:26 AM, Thomas Huth wrote: On 15.08.2017 10:01, Thomas Huth wrote: On 15.08.2017 09:03, Cornelia Huck wrote: On Tue, 15 Aug 2017 07:02:10 +0200 Thomas Huth wrote: On 14.08.2017 22:44, Eric Farman wrote: How often does one really do a "make clean" ? Rather infrequently, as

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Peter Maydell
On 14 August 2017 at 21:44, Eric Farman wrote: > How often does one really do a "make clean" ? Rather infrequently, > as I only stumbled on this today. FWIW, one of my standard pre-merge build tests does a "make clean" and then a make (mostly as a check that we do build from clean as well as inc

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Thomas Huth
On 15.08.2017 10:32, Cornelia Huck wrote: > On Tue, 15 Aug 2017 10:26:18 +0200 > Thomas Huth wrote: [...] >> The parameter -R disables the built-in variables, so RM can indeed not >> work here. Sorry, I wasn't aware of that setting yet, so your patch is >> indeed the right fix here (or we should m

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Cornelia Huck
On Tue, 15 Aug 2017 10:26:18 +0200 Thomas Huth wrote: > On 15.08.2017 10:01, Thomas Huth wrote: > > On 15.08.2017 09:03, Cornelia Huck wrote: > >> On Tue, 15 Aug 2017 07:02:10 +0200 > >> Thomas Huth wrote: > >> > >>> On 14.08.2017 22:44, Eric Farman wrote: > How often does one really

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Thomas Huth
On 15.08.2017 10:01, Thomas Huth wrote: > On 15.08.2017 09:03, Cornelia Huck wrote: >> On Tue, 15 Aug 2017 07:02:10 +0200 >> Thomas Huth wrote: >> >>> On 14.08.2017 22:44, Eric Farman wrote: How often does one really do a "make clean" ? Rather infrequently, as I only stumbled on this to

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Thomas Huth
On 15.08.2017 09:03, Cornelia Huck wrote: > On Tue, 15 Aug 2017 07:02:10 +0200 > Thomas Huth wrote: > >> On 14.08.2017 22:44, Eric Farman wrote: >>> How often does one really do a "make clean" ? Rather infrequently, >>> as I only stumbled on this today. >>> >>> Perhaps I have missed the RM varia

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Cornelia Huck
On Tue, 15 Aug 2017 07:02:10 +0200 Thomas Huth wrote: > On 14.08.2017 22:44, Eric Farman wrote: > > How often does one really do a "make clean" ? Rather infrequently, > > as I only stumbled on this today. > > > > Perhaps I have missed the RM variable somewhere, as I see similar syntax > > in so

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-14 Thread Thomas Huth
On 14.08.2017 22:44, Eric Farman wrote: > How often does one really do a "make clean" ? Rather infrequently, > as I only stumbled on this today. > > Perhaps I have missed the RM variable somewhere, as I see similar syntax > in some of the tests/tcg/ Makefiles, but I don't see it being set here. >

[Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-14 Thread Eric Farman
How often does one really do a "make clean" ? Rather infrequently, as I only stumbled on this today. Perhaps I have missed the RM variable somewhere, as I see similar syntax in some of the tests/tcg/ Makefiles, but I don't see it being set here. My configure statement isn't terribly interesting,