Re: [Qemu-devel] [PATCH for-2.10] util/oslib-posix.c: Avoid warning on NetBSD

2017-07-21 Thread Peter Maydell
On 20 July 2017 at 19:26, Eric Blake wrote: > On 07/20/2017 11:32 AM, Peter Maydell wrote: >> On NetBSD the compiler warns: >> util/oslib-posix.c: In function 'sigaction_invoke': >> util/oslib-posix.c:589:5: warning: missing braces around initializer >> [-Wmissing-braces] >> siginfo_t si = {

Re: [Qemu-devel] [PATCH for-2.10] util/oslib-posix.c: Avoid warning on NetBSD

2017-07-20 Thread Peter Maydell
On 20 July 2017 at 22:10, Eric Blake wrote: > On 07/20/2017 03:53 PM, Peter Maydell wrote: >> On 20 July 2017 at 19:26, Eric Blake wrote: >>> On 07/20/2017 11:32 AM, Peter Maydell wrote: On NetBSD the compiler warns: util/oslib-posix.c: In function 'sigaction_invoke': util/oslib-po

Re: [Qemu-devel] [PATCH for-2.10] util/oslib-posix.c: Avoid warning on NetBSD

2017-07-20 Thread Eric Blake
On 07/20/2017 03:53 PM, Peter Maydell wrote: > On 20 July 2017 at 19:26, Eric Blake wrote: >> On 07/20/2017 11:32 AM, Peter Maydell wrote: >>> On NetBSD the compiler warns: >>> util/oslib-posix.c: In function 'sigaction_invoke': >>> util/oslib-posix.c:589:5: warning: missing braces around initiali

Re: [Qemu-devel] [PATCH for-2.10] util/oslib-posix.c: Avoid warning on NetBSD

2017-07-20 Thread Peter Maydell
On 20 July 2017 at 19:26, Eric Blake wrote: > On 07/20/2017 11:32 AM, Peter Maydell wrote: >> On NetBSD the compiler warns: >> util/oslib-posix.c: In function 'sigaction_invoke': >> util/oslib-posix.c:589:5: warning: missing braces around initializer >> [-Wmissing-braces] >> siginfo_t si = {

Re: [Qemu-devel] [PATCH for-2.10] util/oslib-posix.c: Avoid warning on NetBSD

2017-07-20 Thread Eric Blake
On 07/20/2017 11:32 AM, Peter Maydell wrote: > On NetBSD the compiler warns: > util/oslib-posix.c: In function 'sigaction_invoke': > util/oslib-posix.c:589:5: warning: missing braces around initializer > [-Wmissing-braces] > siginfo_t si = { 0 }; > ^ Uggh. That is a broken compiler. C9

[Qemu-devel] [PATCH for-2.10] util/oslib-posix.c: Avoid warning on NetBSD

2017-07-20 Thread Peter Maydell
On NetBSD the compiler warns: util/oslib-posix.c: In function 'sigaction_invoke': util/oslib-posix.c:589:5: warning: missing braces around initializer [-Wmissing-braces] siginfo_t si = { 0 }; ^ util/oslib-posix.c:589:5: warning: (near initialization for 'si.si_pad') [-Wmissing-braces]