Re: [Qemu-devel] [PATCH for-2.0] Makefile: remove bashism

2014-04-07 Thread Peter Maydell
On 5 April 2014 15:25, Michael Tokarev wrote: > When installing modules (when --enable-modules is specified for > ./configure), Makefile uses the following construct to replace all > slashes with dashes in module name: > > ${s//\//-} > > This is a bash-specific substitution mechanism. POSIX does

Re: [Qemu-devel] [PATCH for-2.0] Makefile: remove bashism

2014-04-07 Thread Peter Maydell
On 7 April 2014 16:30, Markus Armbruster wrote: > Peter Maydell writes: > >> On 5 April 2014 15:25, Michael Tokarev wrote: >>> ifneq ($(CONFIG_MODULES),) >>> $(INSTALL_DIR) "$(DESTDIR)$(qemu_moddir)" >>> for s in $(patsubst %.mo,%$(DSOSUF),$(modules-m)); do \ >>> -

Re: [Qemu-devel] [PATCH for-2.0] Makefile: remove bashism

2014-04-07 Thread Markus Armbruster
Peter Maydell writes: > On 5 April 2014 15:25, Michael Tokarev wrote: >> When installing modules (when --enable-modules is specified for >> ./configure), Makefile uses the following construct to replace all >> slashes with dashes in module name: >> >> ${s//\//-} >> >> This is a bash-specific su

Re: [Qemu-devel] [PATCH for-2.0] Makefile: remove bashism

2014-04-07 Thread Peter Maydell
On 5 April 2014 15:25, Michael Tokarev wrote: > When installing modules (when --enable-modules is specified for > ./configure), Makefile uses the following construct to replace all > slashes with dashes in module name: > > ${s//\//-} > > This is a bash-specific substitution mechanism. POSIX does

[Qemu-devel] [PATCH for-2.0] Makefile: remove bashism

2014-04-05 Thread Michael Tokarev
When installing modules (when --enable-modules is specified for ./configure), Makefile uses the following construct to replace all slashes with dashes in module name: ${s//\//-} This is a bash-specific substitution mechanism. POSIX does not have it, and some operating systems (for example Debia