Re: [Qemu-devel] [PATCH for-1.5 1/2] qom: aggressively optimize qom casting

2013-05-14 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.5 1/2] qom: aggressively optimize qom casting

2013-05-13 Thread Anthony Liguori
Peter Maydell writes: > On 13 May 2013 21:31, Anthony Liguori wrote: >> This patch adds a small typename cache to ObjectClass. This allows >> caching positive casts within each ObjectClass. Benchmarking a >> PPC workload provided by Aurelien, this patch eliminates every >> single g_hash_table_

Re: [Qemu-devel] [PATCH for-1.5 1/2] qom: aggressively optimize qom casting

2013-05-13 Thread Peter Maydell
On 13 May 2013 21:31, Anthony Liguori wrote: > This patch adds a small typename cache to ObjectClass. This allows > caching positive casts within each ObjectClass. Benchmarking a > PPC workload provided by Aurelien, this patch eliminates every > single g_hash_table_lookup() happening during the

Re: [Qemu-devel] [PATCH for-1.5 1/2] qom: aggressively optimize qom casting

2013-05-13 Thread Paolo Bonzini
Il 13/05/2013 23:04, Anthony Liguori ha scritto: > We should leave the --disable-qom-casts present for 1.5 but I'd like > to discuss reverting it for 1.6. I'll send patches once 1.6 opens up. I disagree, the cost is small but still provably nonzero. We should only remove it once interfaces start

Re: [Qemu-devel] [PATCH for-1.5 1/2] qom: aggressively optimize qom casting

2013-05-13 Thread Anthony Liguori
Paolo Bonzini writes: > Il 13/05/2013 22:31, Anthony Liguori ha scritto: >> This patch adds a small typename cache to ObjectClass. This allows >> caching positive casts within each ObjectClass. Benchmarking a >> PPC workload provided by Aurelien, this patch eliminates every >> single g_hash_tab

Re: [Qemu-devel] [PATCH for-1.5 1/2] qom: aggressively optimize qom casting

2013-05-13 Thread Paolo Bonzini
Il 13/05/2013 22:31, Anthony Liguori ha scritto: > This patch adds a small typename cache to ObjectClass. This allows > caching positive casts within each ObjectClass. Benchmarking a > PPC workload provided by Aurelien, this patch eliminates every > single g_hash_table_lookup() happening during t

[Qemu-devel] [PATCH for-1.5 1/2] qom: aggressively optimize qom casting

2013-05-13 Thread Anthony Liguori
This patch adds a small typename cache to ObjectClass. This allows caching positive casts within each ObjectClass. Benchmarking a PPC workload provided by Aurelien, this patch eliminates every single g_hash_table_lookup() happening during the benchmark (which was about 2 million per-second). Wit