Re: [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptyness check

2014-02-11 Thread Michael Tokarev
11.02.2014 10:49, Peter Crosthwaite wrote: > This was guarding against a full fifo rather than an empty fifo when > popping. Fix. I've applied this to qemu-trivial for now, if no one will pick it up before the next -trivial pull, -- because the original change were merged using -trivial too. I al

Re: [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptyness check

2014-02-11 Thread Martin Kletzander
On Mon, Feb 10, 2014 at 10:49:35PM -0800, Peter Crosthwaite wrote: > This was guarding against a full fifo rather than an empty fifo when > popping. Fix. > > Signed-off-by: Peter Crosthwaite > --- Reviewed-by: Martin Kletzander With this patch qemu doesn't crash in my use-case. > > hw/char/se

Re: [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptyness check

2014-02-11 Thread Dr. David Alan Gilbert
* Peter Crosthwaite (peter.crosthwa...@xilinx.com) wrote: > This was guarding against a full fifo rather than an empty fifo when > popping. Fix. > > Signed-off-by: Peter Crosthwaite > --- Reviewed-by: Dr. David Alan Gilbert I think this brings it back to how it was on the old FIFO code. > >

[Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptyness check

2014-02-10 Thread Peter Crosthwaite
This was guarding against a full fifo rather than an empty fifo when popping. Fix. Signed-off-by: Peter Crosthwaite --- hw/char/serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index 27dab7d..6d3b5af 100644 --- a/hw/char/serial.c +