Re: [Qemu-devel] [PATCH alt 3/7] qemu-img: Fix insignifcant memleak

2014-07-31 Thread Benoît Canet
The Saturday 26 Jul 2014 à 21:22:07 (+0200), Max Reitz wrote : > As soon as options is set in img_amend(), it needs to be freed before > the function returns. This leak is rather insignifcant, as qemu-img will > exit subsequently anyway, but there's no point in not fixing it. > > Signed-off-by: M

Re: [Qemu-devel] [PATCH alt 3/7] qemu-img: Fix insignifcant memleak

2014-07-30 Thread Max Reitz
On 30.07.2014 16:58, Eric Blake wrote: On 07/26/2014 01:22 PM, Max Reitz wrote: As soon as options is set in img_amend(), it needs to be freed before the function returns. This leak is rather insignifcant, as qemu-img will s/insignifcant/insignificant/ I wonder how I was able to get it wrong

Re: [Qemu-devel] [PATCH alt 3/7] qemu-img: Fix insignifcant memleak

2014-07-30 Thread Eric Blake
On 07/26/2014 01:22 PM, Max Reitz wrote: > As soon as options is set in img_amend(), it needs to be freed before > the function returns. This leak is rather insignifcant, as qemu-img will s/insignifcant/insignificant/ > exit subsequently anyway, but there's no point in not fixing it. > > Signed-

[Qemu-devel] [PATCH alt 3/7] qemu-img: Fix insignifcant memleak

2014-07-26 Thread Max Reitz
As soon as options is set in img_amend(), it needs to be freed before the function returns. This leak is rather insignifcant, as qemu-img will exit subsequently anyway, but there's no point in not fixing it. Signed-off-by: Max Reitz --- qemu-img.c | 4 +++- 1 file changed, 3 insertions(+), 1 del