Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-08 Thread Stefan Berger
On 09/08/2011 09:16 AM, Michael S. Tsirkin wrote: On Thu, Sep 08, 2011 at 08:11:00AM -0400, Stefan Berger wrote: On 09/08/2011 06:32 AM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2011 at 08:16:27PM -0400, Stefan Berger wrote: On 09/07/2011 02:55 PM, Michael S. Tsirkin wrote: On Thu, Sep 01, 2

Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-08 Thread Michael S. Tsirkin
On Thu, Sep 08, 2011 at 08:11:00AM -0400, Stefan Berger wrote: > On 09/08/2011 06:32 AM, Michael S. Tsirkin wrote: > >On Wed, Sep 07, 2011 at 08:16:27PM -0400, Stefan Berger wrote: > >>On 09/07/2011 02:55 PM, Michael S. Tsirkin wrote: > >>>On Thu, Sep 01, 2011 at 10:23:51PM -0400, Stefan Berger wro

Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-08 Thread Stefan Berger
On 09/08/2011 06:32 AM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2011 at 08:16:27PM -0400, Stefan Berger wrote: On 09/07/2011 02:55 PM, Michael S. Tsirkin wrote: On Thu, Sep 01, 2011 at 10:23:51PM -0400, Stefan Berger wrote: An additional 'layer' for reading and writing the blobs to the under

Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-08 Thread Michael S. Tsirkin
On Wed, Sep 07, 2011 at 08:16:27PM -0400, Stefan Berger wrote: > On 09/07/2011 02:55 PM, Michael S. Tsirkin wrote: > >On Thu, Sep 01, 2011 at 10:23:51PM -0400, Stefan Berger wrote: > An additional 'layer' for reading and writing the blobs to the underlying > block storage is added. This lay

Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-07 Thread Stefan Berger
On 09/07/2011 02:55 PM, Michael S. Tsirkin wrote: On Thu, Sep 01, 2011 at 10:23:51PM -0400, Stefan Berger wrote: An additional 'layer' for reading and writing the blobs to the underlying block storage is added. This layer encrypts the blobs for writing if a key is available. Similarly it decrypt

Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-07 Thread Michael S. Tsirkin
On Thu, Sep 01, 2011 at 10:23:51PM -0400, Stefan Berger wrote: > >>An additional 'layer' for reading and writing the blobs to the underlying > >>block storage is added. This layer encrypts the blobs for writing if a key > >>is > >>available. Similarly it decrypts the blobs after reading. So a cou

Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-07 Thread Michael S. Tsirkin
On Tue, Sep 06, 2011 at 08:32:41PM -0400, Stefan Berger wrote: > To summarize it: > enc_mode=# redundant for now since this is the only > supported encryption scheme; so could drop it and assume as default > > key_format= # hex for a string hex number; binary would > mean the found string

Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-06 Thread Stefan Berger
On 09/04/2011 12:58 PM, Michael S. Tsirkin wrote: On Thu, Sep 01, 2011 at 10:23:51PM -0400, Stefan Berger wrote: Checks are added that test - whether encryption is supported follwing the revision of the directory structure (rev>= 2) You never generate rev 1 code, right? I did this in the pr

Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-04 Thread Michael S. Tsirkin
On Thu, Sep 01, 2011 at 10:23:51PM -0400, Stefan Berger wrote: > >>Checks are added that test > >>- whether encryption is supported follwing the revision of the directory > >> structure (rev>= 2) > >You never generate rev 1 code, right? > I did this in the previous patch that implemented rev 1 th

Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-01 Thread Stefan Berger
On 09/01/2011 03:26 PM, Michael S. Tsirkin wrote: On Wed, Aug 31, 2011 at 10:36:01AM -0400, Stefan Berger wrote: This patch adds encryption of the individual state blobs that are written into the block storage. The 'directory' at the beginnig of the block storage is not encrypted. Does this mea

Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-01 Thread Michael S. Tsirkin
On Wed, Aug 31, 2011 at 10:36:01AM -0400, Stefan Berger wrote: > This patch adds encryption of the individual state blobs that are written > into the block storage. The 'directory' at the beginnig of the block > storage is not encrypted. Does this mean that there's a new format that we store data

[Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-08-31 Thread Stefan Berger
This patch adds encryption of the individual state blobs that are written into the block storage. The 'directory' at the beginnig of the block storage is not encrypted. The encryption support added in this patch would also work if QCoW2 was not to be used as the (only) image file format to store t