Re: [Qemu-devel] [PATCH V5 2/8] snapshot: distinguish id and name in snapshot delete

2013-07-19 Thread Wenchao Xia
于 2013-7-18 19:48, Kevin Wolf 写道: Am 11.07.2013 um 07:46 hat Wenchao Xia geschrieben: Snapshot creation actually already distinguish id and name since it take a structured parameter *sn, but delete can't. Later an accurate delete is needed in qmp_transaction abort and blockdev-snapshot-delete-sy

Re: [Qemu-devel] [PATCH V5 2/8] snapshot: distinguish id and name in snapshot delete

2013-07-19 Thread Wenchao Xia
于 2013-7-18 19:07, Stefan Hajnoczi 写道: On Thu, Jul 11, 2013 at 01:46:58PM +0800, Wenchao Xia wrote: diff --git a/include/qemu-common.h b/include/qemu-common.h index f439738..06c777f 100644 --- a/include/qemu-common.h +++ b/include/qemu-common.h @@ -191,6 +191,9 @@ int64_t strtosz_suffix(const ch

Re: [Qemu-devel] [PATCH V5 2/8] snapshot: distinguish id and name in snapshot delete

2013-07-18 Thread Kevin Wolf
Am 11.07.2013 um 07:46 hat Wenchao Xia geschrieben: > Snapshot creation actually already distinguish id and name since it take > a structured parameter *sn, but delete can't. Later an accurate delete > is needed in qmp_transaction abort and blockdev-snapshot-delete-sync, > so change its prototype.

Re: [Qemu-devel] [PATCH V5 2/8] snapshot: distinguish id and name in snapshot delete

2013-07-18 Thread Stefan Hajnoczi
On Thu, Jul 11, 2013 at 01:46:58PM +0800, Wenchao Xia wrote: > diff --git a/include/qemu-common.h b/include/qemu-common.h > index f439738..06c777f 100644 > --- a/include/qemu-common.h > +++ b/include/qemu-common.h > @@ -191,6 +191,9 @@ int64_t strtosz_suffix(const char *nptr, char **end, > const c

[Qemu-devel] [PATCH V5 2/8] snapshot: distinguish id and name in snapshot delete

2013-07-10 Thread Wenchao Xia
Snapshot creation actually already distinguish id and name since it take a structured parameter *sn, but delete can't. Later an accurate delete is needed in qmp_transaction abort and blockdev-snapshot-delete-sync, so change its prototype. Also *errp is added to tip error, but return value is kepted