Re: [Qemu-devel] [PATCH V5 1/4] Implement sync modes for drive-backup.

2013-07-19 Thread Ian Main
On Fri, Jul 19, 2013 at 04:11:13PM -0600, Eric Blake wrote: > On 07/19/2013 03:49 PM, Ian Main wrote: > >>> +++ b/qapi-schema.json > >>> @@ -1807,6 +1807,10 @@ > >>> # @format: #optional the format of the new destination, default is to > >>> # probe if @mode is 'existing', else the forma

Re: [Qemu-devel] [PATCH V5 1/4] Implement sync modes for drive-backup.

2013-07-19 Thread Ian Main
On Fri, Jul 19, 2013 at 01:41:10PM -0600, Eric Blake wrote: > On 07/19/2013 11:03 AM, Ian Main wrote: > > This patch adds sync-modes to the drive-backup interface and > > implements the FULL, NONE and TOP modes of synchronization. > > > > > Signed-off-by: Ian Main > > --- > > block/backup.c

Re: [Qemu-devel] [PATCH V5 1/4] Implement sync modes for drive-backup.

2013-07-19 Thread Eric Blake
On 07/19/2013 11:03 AM, Ian Main wrote: > This patch adds sync-modes to the drive-backup interface and > implements the FULL, NONE and TOP modes of synchronization. > > Signed-off-by: Ian Main > --- > block/backup.c| 91 > +++ > blockdev.

Re: [Qemu-devel] [PATCH V5 1/4] Implement sync modes for drive-backup.

2013-07-19 Thread Eric Blake
On 07/19/2013 03:49 PM, Ian Main wrote: >>> +++ b/qapi-schema.json >>> @@ -1807,6 +1807,10 @@ >>> # @format: #optional the format of the new destination, default is to >>> # probe if @mode is 'existing', else the format of the source >>> # >>> +# @sync: what parts of the disk image shou

[Qemu-devel] [PATCH V5 1/4] Implement sync modes for drive-backup.

2013-07-19 Thread Ian Main
This patch adds sync-modes to the drive-backup interface and implements the FULL, NONE and TOP modes of synchronization. FULL performs as before copying the entire contents of the drive while preserving the point-in-time using CoW. NONE only copies new writes to the target drive. TOP copies change