Re: [Qemu-devel] [PATCH V5] hw/virtio: Add PCIe capability to virtio devices

2015-12-01 Thread Marcel Apfelbaum
On 12/01/2015 04:19 PM, Shmulik Ladkani wrote: Hi, On Tue, 1 Dec 2015 16:01:00 +0200, mar...@redhat.com wrote: On 12/01/2015 03:18 PM, Shmulik Ladkani wrote: On Tue, 1 Dec 2015 13:48:13 +0200, mar...@redhat.com wrote: May I suggest the following: - Expose 'pci_qdev_realize' - Have 'virtio_pci

Re: [Qemu-devel] [PATCH V5] hw/virtio: Add PCIe capability to virtio devices

2015-12-01 Thread Shmulik Ladkani
Hi, On Tue, 1 Dec 2015 16:01:00 +0200, mar...@redhat.com wrote: > On 12/01/2015 03:18 PM, Shmulik Ladkani wrote: > > On Tue, 1 Dec 2015 13:48:13 +0200, mar...@redhat.com wrote: > >>> May I suggest the following: > >>> - Expose 'pci_qdev_realize' > >>> - Have 'virtio_pci_class_init' arm it's own dc

Re: [Qemu-devel] [PATCH V5] hw/virtio: Add PCIe capability to virtio devices

2015-12-01 Thread Marcel Apfelbaum
On 12/01/2015 03:18 PM, Shmulik Ladkani wrote: Hi, On Tue, 1 Dec 2015 13:48:13 +0200, mar...@redhat.com wrote: May I suggest the following: - Expose 'pci_qdev_realize' - Have 'virtio_pci_class_init' arm it's own dc->realize, which will first set 'QEMU_PCI_CAP_EXPRESS' flag as needed, an

Re: [Qemu-devel] [PATCH V5] hw/virtio: Add PCIe capability to virtio devices

2015-12-01 Thread Shmulik Ladkani
Hi, On Tue, 1 Dec 2015 13:48:13 +0200, mar...@redhat.com wrote: > > May I suggest the following: > > - Expose 'pci_qdev_realize' > > - Have 'virtio_pci_class_init' arm it's own dc->realize, > >which will first set 'QEMU_PCI_CAP_EXPRESS' flag as needed, > >and then call 'pci_qdev_realize' >

Re: [Qemu-devel] [PATCH V5] hw/virtio: Add PCIe capability to virtio devices

2015-12-01 Thread Marcel Apfelbaum
On 12/01/2015 12:29 PM, Shmulik Ladkani wrote: Hi, On Tue, 10 Nov 2015 13:41:29 +0200, mar...@redhat.com wrote: The virtio devices are converted to PCI-Express if they are plugged into a PCI-Express bus and the 'modern' protocol is enabled. @@ -1592,6 +1592,26 @@ static void virtio_pci_realize

Re: [Qemu-devel] [PATCH V5] hw/virtio: Add PCIe capability to virtio devices

2015-12-01 Thread Shmulik Ladkani
Hi, On Tue, 10 Nov 2015 13:41:29 +0200, mar...@redhat.com wrote: > The virtio devices are converted to PCI-Express > if they are plugged into a PCI-Express bus and > the 'modern' protocol is enabled. > > @@ -1592,6 +1592,26 @@ static void virtio_pci_realize(PCIDevice *pci_dev, > Error **errp) >

[Qemu-devel] [PATCH V5] hw/virtio: Add PCIe capability to virtio devices

2015-11-10 Thread Marcel Apfelbaum
The virtio devices are converted to PCI-Express if they are plugged into a PCI-Express bus and the 'modern' protocol is enabled. Devices plugged directly into the Root Complex as Integrated Endpoints remain PCI. Signed-off-by: Marcel Apfelbaum --- v4 -> v5: - Addressed Michael S. Tsirkin's comm