Re: [Qemu-devel] [PATCH V4 for 3.1 1/4] net: drop too large packet early

2018-12-03 Thread Jason Wang
On 2018/12/4 上午2:13, Thomas Huth wrote: On 2018-12-03 11:06, Jason Wang wrote: We try to detect and drop too large packet (>INT_MAX) in 1592a9947036 ("net: ignore packet size greater than INT_MAX") during packet delivering. Unfortunately, this is not sufficient as we may hit another integer ov

Re: [Qemu-devel] [PATCH V4 for 3.1 1/4] net: drop too large packet early

2018-12-03 Thread Jason Wang
On 2018/12/4 上午12:18, Eric Blake wrote: On 12/3/18 4:06 AM, Jason Wang wrote: We try to detect and drop too large packet (>INT_MAX) in 1592a9947036 ("net: ignore packet size greater than INT_MAX") during packet delivering. Unfortunately, this is not sufficient as we may hit another integer ove

Re: [Qemu-devel] [PATCH V4 for 3.1 1/4] net: drop too large packet early

2018-12-03 Thread Thomas Huth
On 2018-12-03 11:06, Jason Wang wrote: > We try to detect and drop too large packet (>INT_MAX) in 1592a9947036 > ("net: ignore packet size greater than INT_MAX") during packet > delivering. Unfortunately, this is not sufficient as we may hit > another integer overflow when trying to queue such larg

Re: [Qemu-devel] [PATCH V4 for 3.1 1/4] net: drop too large packet early

2018-12-03 Thread Eric Blake
On 12/3/18 4:06 AM, Jason Wang wrote: We try to detect and drop too large packet (>INT_MAX) in 1592a9947036 ("net: ignore packet size greater than INT_MAX") during packet delivering. Unfortunately, this is not sufficient as we may hit another integer overflow when trying to queue such large packe

[Qemu-devel] [PATCH V4 for 3.1 1/4] net: drop too large packet early

2018-12-03 Thread Jason Wang
We try to detect and drop too large packet (>INT_MAX) in 1592a9947036 ("net: ignore packet size greater than INT_MAX") during packet delivering. Unfortunately, this is not sufficient as we may hit another integer overflow when trying to queue such large packet in qemu_net_queue_append_iov(): - siz