Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system

2012-09-28 Thread Wenchao Xia
于 2012-9-28 15:52, Paolo Bonzini 写道: Il 28/09/2012 05:04, Wenchao Xia ha scritto: +$(LIBQBLOCK_TEST_DIR): +@echo "Make libqblock test directory" +mkdir $(LIBQBLOCK_TEST_DIR) You can leave the files in tests/ directly, and avoid this as well. Having a new directory will make clean

Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system

2012-09-28 Thread Paolo Bonzini
Il 28/09/2012 05:04, Wenchao Xia ha scritto: > +$(LIBQBLOCK_TEST_DIR): > +@echo "Make libqblock test directory" > +mkdir $(LIBQBLOCK_TEST_DIR) You can leave the files in tests/ directly, and avoid this as well. >>>Having a new directory will make clean easier, othe

Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system

2012-09-27 Thread Wenchao Xia
于 2012-9-27 18:17, Paolo Bonzini 写道: Il 27/09/2012 11:56, Wenchao Xia ha scritto: +$(LIBQBLOCK_TEST_DIR): +@echo "Make libqblock test directory" +mkdir $(LIBQBLOCK_TEST_DIR) You can leave the files in tests/ directly, and avoid this as well. Having a new directory will make clean

Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 11:56, Wenchao Xia ha scritto: >> >>> +$(LIBQBLOCK_TEST_DIR): >>> +@echo "Make libqblock test directory" >>> +mkdir $(LIBQBLOCK_TEST_DIR) >> >> You can leave the files in tests/ directly, and avoid this as well. > Having a new directory will make clean easier, otherwise the

Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system

2012-09-27 Thread Wenchao Xia
于 2012-9-27 16:30, Paolo Bonzini 写道: Il 27/09/2012 04:24, Wenchao Xia ha scritto: +#libqblock +LIBQBLOCK_TEST_DIR=$(SRC_PATH)/tests/libqblock/test_images +qtest-lib-y=$(patsubst %.o, %.lo,$(qtest-obj-y)) I don't think you need qtest-obj-y for anything. OK, I will remove it. +libqblock-la-

Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 04:24, Wenchao Xia ha scritto: > +#libqblock > +LIBQBLOCK_TEST_DIR=$(SRC_PATH)/tests/libqblock/test_images > +qtest-lib-y=$(patsubst %.o, %.lo,$(qtest-obj-y)) I don't think you need qtest-obj-y for anything. > +libqblock-la-path = $(libqblock-lib-path)/$(libqblock-lib-la) > + > +tes

[Qemu-devel] [PATCH V4 4/5] libqblock test build system

2012-09-26 Thread Wenchao Xia
This patch will create a new directory in ./tests, make check-libqblock will build an executable binary, make clean or make check-clean will delete generated binaries. Signed-off-by: Wenchao Xia --- .gitignore|2 + Makefile |1 + tests/M