Re: [Qemu-devel] [PATCH V4 08/12] hw/sd.c: add SD card save/load support

2012-08-08 Thread Peter Maydell
On 31 July 2012 19:18, Igor Mitsyanko wrote: > On 07/31/2012 06:56 PM, Peter Maydell wrote: >> On 27 July 2012 20:29, Igor Mitsyanko wrote: >>> >>> +VMSTATE_BUFFER_MULTIPLY(wp_groups, SDState, 1, NULL, 0, >>> wpgrps_size, >>> +sizeof(unsigned long)), >> >> >> Isn't this tr

Re: [Qemu-devel] [PATCH V4 08/12] hw/sd.c: add SD card save/load support

2012-07-31 Thread Igor Mitsyanko
On 07/31/2012 06:56 PM, Peter Maydell wrote: On 27 July 2012 20:29, Igor Mitsyanko wrote: +VMSTATE_BUFFER_MULTIPLY(wp_groups, SDState, 1, NULL, 0, wpgrps_size, +sizeof(unsigned long)), Isn't this trying to use wpgrps_size as the number of unsigned longs in the bitmap,

Re: [Qemu-devel] [PATCH V4 08/12] hw/sd.c: add SD card save/load support

2012-07-31 Thread Peter Maydell
On 27 July 2012 20:29, Igor Mitsyanko wrote: > +VMSTATE_BUFFER_MULTIPLY(wp_groups, SDState, 1, NULL, 0, wpgrps_size, > +sizeof(unsigned long)), Isn't this trying to use wpgrps_size as the number of unsigned longs in the bitmap, when it's actually the size of the bitmap in

Re: [Qemu-devel] [PATCH V4 08/12] hw/sd.c: add SD card save/load support

2012-07-31 Thread Igor Mitsyanko
On 07/31/2012 01:33 PM, Markus Armbruster wrote: Igor Mitsyanko writes: This patch updates SD card model to support save/load of card's state. Signed-off-by: Igor Mitsyanko --- hw/sd.c | 88 +- 1 files changed, 64 insertions(+)

Re: [Qemu-devel] [PATCH V4 08/12] hw/sd.c: add SD card save/load support

2012-07-31 Thread Markus Armbruster
Igor Mitsyanko writes: > This patch updates SD card model to support save/load of card's state. > > Signed-off-by: Igor Mitsyanko > --- > hw/sd.c | 88 +- > 1 files changed, 64 insertions(+), 24 deletions(-) > > diff --git a/hw/sd.c

[Qemu-devel] [PATCH V4 08/12] hw/sd.c: add SD card save/load support

2012-07-27 Thread Igor Mitsyanko
This patch updates SD card model to support save/load of card's state. Signed-off-by: Igor Mitsyanko --- hw/sd.c | 88 +- 1 files changed, 64 insertions(+), 24 deletions(-) diff --git a/hw/sd.c b/hw/sd.c index 20ebd8e..f8ab045 100644