Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-30 Thread Deniz Eren
Hi Paolo, Thank you for the correction! Greatly appreciated and it worked. I tested all combinations of Linux host using virtual Socket-CAN and pcm3680 and mioe3680 client QEmu Linux environments using Linux Socket-CAN drivers, sending and receiving from each-other (all combinations; host-

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-30 Thread Deniz Eren
Hi Pavel, Paolo, I tried to rerun my environment to test however it seems the interface has changed a little and my standard program options cause complaints. Unfortunately I don’t have too much time to dig through at the moment. My standard startup command is: $ ./qemu-local/bin/qemu-system-i

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-30 Thread Paolo Bonzini
On 30/01/2018 20:08, Paolo Bonzini wrote: > On 30/01/2018 19:13, Deniz Eren wrote: >> Hi Pavel, Paolo, >> >> I tried to rerun my environment to test however it seems the interface has >> changed a little and my standard program options cause complaints. >> Unfortunately I don’t have too much time

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-30 Thread Paolo Bonzini
On 30/01/2018 19:13, Deniz Eren wrote: > Hi Pavel, Paolo, > > I tried to rerun my environment to test however it seems the interface has > changed a little and my standard program options cause complaints. > Unfortunately I don’t have too much time to dig through at the moment. > > My standard

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-30 Thread Pavel Pisa
Hello Paolo, thanks much for conversion to acceptable QOM model. On Tuesday 30 of January 2018 15:15:22 Paolo Bonzini wrote: > On 25/01/2018 22:33, Pavel Pisa wrote: > > Hello Paolo, > > > > thanks for suggestions. I understand and fully agree with your > > request to switch to QOM. I have succee

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-30 Thread Paolo Bonzini
On 25/01/2018 22:33, Pavel Pisa wrote: > Hello Paolo, > > thanks for suggestions. I understand and fully agree with your > request to switch to QOM. I have succeed with that for CAN devices > some time ago. It worth to be done for the rest of the objects > but I fear that I do not find time to com

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-28 Thread Oleksij Rempel
Hi, On 28.01.2018 10:02, Pavel Pisa wrote: > Hello Paolo, > > On Friday 26 of January 2018 12:12:32 Paolo Bonzini wrote: >> Coincidentially, I have some time on a flight next Monday. :) I >> obviously cannot really _test_ anything, but I can at least do the >> changes below and set up all the QO

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-28 Thread Pavel Pisa
Hello Paolo, On Friday 26 of January 2018 12:12:32 Paolo Bonzini wrote: > Coincidentially, I have some time on a flight next Monday. :) I > obviously cannot really _test_ anything, but I can at least do the > changes below and set up all the QOM boilerplate. thanks much for offer to help. Deniz

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-26 Thread Paolo Bonzini
On 25/01/2018 22:33, Pavel Pisa wrote: > Hello Paolo, > > thanks for suggestions. I understand and fully agree with your > request to switch to QOM. I have succeed with that for CAN devices > some time ago. It worth to be done for the rest of the objects > but I fear that I do not find time to com

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-25 Thread Pavel Pisa
Hello Paolo, thanks for suggestions. I understand and fully agree with your request to switch to QOM. I have succeed with that for CAN devices some time ago. It worth to be done for the rest of the objects but I fear that I do not find time to complete QOMification in reasonable future. Contributi

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-25 Thread Paolo Bonzini
On 23/01/2018 22:42, Pavel Pisa wrote: > Do you think QOM based? I would like it to be implemented > that way but I need some assistance where to look how this > object kind should be implemented and from which base object > inherit from. But I prefer to left that for later work. > > I would defin

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-25 Thread Deniz Eren
Hi Pavel, Philippe, I’m happy with whatever way is best for the project. However I would personally think merging the different drivers into one C file would not be a very modular way of handling the problem. As you can see from the Advantech drivers for example, the card supplier end can pose

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-25 Thread Pavel Pisa
Hello Philippe, On Wednesday 24 of January 2018 22:41:16 Philippe Mathieu-Daudé wrote: > Hi Pavel, > > I have seen that a few other type_init-s do more > > than simple sequence of type_register_static(). > > Is it acceptable to use type_init for registration > > to CAN core by function call for no

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-24 Thread Philippe Mathieu-Daudé
Hi Pavel, On 01/24/2018 05:22 PM, Pavel Pisa wrote: > Hello everybody, > > On Tuesday 23 of January 2018 22:42:31 Pavel Pisa wrote: >> When Linux specific object file is linked in then some local >> function needs to be called before QOM instances population. >> I know how to do that GCC specific

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-24 Thread Pavel Pisa
Hello everybody, On Tuesday 23 of January 2018 22:42:31 Pavel Pisa wrote: > When Linux specific object file is linked in then some local > function needs to be called before QOM instances population. > I know how to do that GCC specific/non-portable way > > static void __attribute__((constructor))

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-23 Thread Pavel Pisa
Hello Philippe, On Monday 22 of January 2018 12:35:33 Philippe Mathieu-Daudé wrote: > Hi Pavel, > > On 01/14/2018 05:14 PM, p...@cmp.felk.cvut.cz wrote: > > I think your series is quite ready to get accepted, although I'm not > sure through with tree it will goes. > > Most of my review comments ar

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-22 Thread Philippe Mathieu-Daudé
Hi Pavel, On 01/14/2018 05:14 PM, p...@cmp.felk.cvut.cz wrote: > From: Pavel Pisa > > Basic emulation of CAN bus controller and interconnection for QEMU. > > Patches version 4: > Resolve comments longer than 80 characters to suppress > all warnings reported by scripts/checkpatch.pl. > Follow al

[Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-14 Thread pisa
From: Pavel Pisa Basic emulation of CAN bus controller and interconnection for QEMU. Patches version 4: Resolve comments longer than 80 characters to suppress all warnings reported by scripts/checkpatch.pl. Follow all suggestions from Frederic Konrad review. Replace all printf and perror calls b