Re: [Qemu-devel] [PATCH V3 4/9] qmp: add internal snapshot support in qmp_transaction

2013-07-04 Thread Stefan Hajnoczi
On Thu, Jun 27, 2013 at 10:41:43AM +0800, Wenchao Xia wrote: > +/* check whether a snapshot with name exist, no need to check id, since > + name will be checked later to make sure it does not mess up with id. > */ > +ret = bdrv_snapshot_find_by_id_and_name(bs, NULL, name, &sn, errp);

[Qemu-devel] [PATCH V3 4/9] qmp: add internal snapshot support in qmp_transaction

2013-06-25 Thread Wenchao Xia
Unlike savevm, the qmp_transaction interface will not generate snapshot name automatically, saving trouble to return information of the new created snapshot. The snapshot name should not mess up with snapshot ID, there is a check for it. Although qcow2 support storing multiple snapshots with same