Re: [Qemu-devel] [PATCH V3 2/2] virtio-block: support auto-sensing of block sizes

2013-02-12 Thread Christian Borntraeger
On 08/02/13 15:52, Einar Lueck wrote: > Virtio-blk does not impose fixed block sizes for access to > backing devices. This patch introduces support for auto > lookup of the block sizes of the backing block device. This > automatic lookup needs to be enabled explicitly. Users may > do this by specif

Re: [Qemu-devel] [PATCH V3 2/2] virtio-block: support auto-sensing of block sizes

2013-02-12 Thread Stefan Hajnoczi
On Fri, Feb 08, 2013 at 03:52:35PM +0100, Einar Lueck wrote: > @@ -22,6 +25,26 @@ void blkconf_serial(BlockConf *conf, char **serial) > } > } > > +void blkconf_blocksizes(BlockConf *conf) > +{ > +int block_size; > + > +if (!conf->physical_block_size) { > +if (bdrv_ioctl(conf

[Qemu-devel] [PATCH V3 2/2] virtio-block: support auto-sensing of block sizes

2013-02-08 Thread Einar Lueck
Virtio-blk does not impose fixed block sizes for access to backing devices. This patch introduces support for auto lookup of the block sizes of the backing block device. This automatic lookup needs to be enabled explicitly. Users may do this by specifying (physical|logical)_block_size=0. Machine ty