Re: [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance

2017-08-20 Thread Zhang Chen
On 08/21/2017 11:55 AM, Jason Wang wrote: On 2017年08月21日 09:45, Zhang Chen wrote: Hi~~ All~ No one review this series for a long time. Ping... Looks ok to me. But I don't like patch 1 since it adds more TODO especially for a non-exist function colo_notify_checkpoint(). I tend to hav

Re: [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance

2017-08-20 Thread Jason Wang
On 2017年08月21日 09:45, Zhang Chen wrote: Hi~~ All~ No one review this series for a long time. Ping... Looks ok to me. But I don't like patch 1 since it adds more TODO especially for a non-exist function colo_notify_checkpoint(). I tend to have it after colo_notify_checkpoint() is implem

Re: [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance

2017-08-20 Thread Zhang Chen
Hi~~ All~ No one review this series for a long time. Ping... Thanks Zhang Chen On 07/19/2017 03:29 PM, Zhang Chen wrote: In this serise, we do a lot of job to optimize COLO net performance. Mainly focus on TCP protocol. V3: - Rebase on upstream. - Remove origin p2. - Move the "check

Re: [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance

2017-07-19 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance Message-id: 1500449399-19107-1-git-send-email-zhangchen.f...@cn.fujitsu.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance

2017-07-19 Thread Zhang Chen
In this serise, we do a lot of job to optimize COLO net performance. Mainly focus on TCP protocol. V3: - Rebase on upstream. - Remove origin p2. - Move the "checkpoint_time_ms" to CompareState, in order to aviod multi colo-compare instance conflict. - Add "TODO comments" for reset s->checkp