Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-09-05 Thread Zhangjie (HZ)
On 2014/9/1 16:18, Michael S. Tsirkin wrote: > On Fri, Aug 29, 2014 at 06:40:24PM +0800, Zhangjie (HZ) wrote: >> >> >> On 2014/8/27 20:59, Michael S. Tsirkin wrote: >>> On Thu, Aug 21, 2014 at 03:42:53PM +0800, Zhangjie (HZ) wrote: On 2014/8/21 14:53, Jason Wang wrote: > On 08/21/2014 02

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-09-01 Thread Michael S. Tsirkin
On Fri, Aug 29, 2014 at 06:40:24PM +0800, Zhangjie (HZ) wrote: > > > On 2014/8/27 20:59, Michael S. Tsirkin wrote: > > On Thu, Aug 21, 2014 at 03:42:53PM +0800, Zhangjie (HZ) wrote: > >> On 2014/8/21 14:53, Jason Wang wrote: > >>> On 08/21/2014 02:28 PM, Zhangjie (HZ) wrote: > > After m

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-29 Thread Zhangjie (HZ)
On 2014/8/27 20:59, Michael S. Tsirkin wrote: > On Thu, Aug 21, 2014 at 03:42:53PM +0800, Zhangjie (HZ) wrote: >> On 2014/8/21 14:53, Jason Wang wrote: >>> On 08/21/2014 02:28 PM, Zhangjie (HZ) wrote: After migration, vhost is not disabled, virtual nic became unreachable because v

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-27 Thread Michael S. Tsirkin
On Thu, Aug 21, 2014 at 03:42:53PM +0800, Zhangjie (HZ) wrote: > On 2014/8/21 14:53, Jason Wang wrote: > > On 08/21/2014 02:28 PM, Zhangjie (HZ) wrote: > >> > >> After migration, vhost is not disabled, virtual nic became unreachable > >> because vhost is not awakened. > >> By the logical of EVENT

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-27 Thread Michael S. Tsirkin
On Wed, Aug 20, 2014 at 05:23:21PM +0800, Zhangjie (HZ) wrote: > On 2014/8/19 12:56, Jason Wang wrote: > > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue > call it before setting > > Zhang Jie, please test this patch to see if it fixes the issue. > > > +static void vhost_net_se

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-21 Thread Jason Wang
On 08/21/2014 02:28 PM, Zhangjie (HZ) wrote: > On 2014/8/21 12:29, Jason Wang wrote: >> > On 08/20/2014 05:23 PM, Zhangjie (HZ) wrote: >>> >> On 2014/8/19 12:56, Jason Wang wrote: >>> commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue >>> >> call it before setting >>> Zhan

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-21 Thread Zhangjie (HZ)
On 2014/8/21 14:53, Jason Wang wrote: > On 08/21/2014 02:28 PM, Zhangjie (HZ) wrote: >> >> After migration, vhost is not disabled, virtual nic became unreachable >> because vhost is not awakened. >> By the logical of EVENT_IDX, virtio-net will not kick vhost again if the >> used idx is not updat

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-21 Thread Zhangjie (HZ)
On 2014/8/21 5:21, Michael S. Tsirkin wrote: > On Wed, Aug 20, 2014 at 12:18:33PM +0200, Michael S. Tsirkin wrote: >>> Because of vhost_net_set_vq_index, VM can be start successfully. >>> But, after about 80 times of migration under my environment, virtual nic >>> became unreachable again. >>> Whe

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-20 Thread Jason Wang
On 08/21/2014 02:28 PM, Zhangjie (HZ) wrote: > On 2014/8/21 12:29, Jason Wang wrote: >> On 08/20/2014 05:23 PM, Zhangjie (HZ) wrote: >>> On 2014/8/19 12:56, Jason Wang wrote: commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue >>> call it before setting Zhang Jie, please te

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-20 Thread Zhangjie (HZ)
On 2014/8/21 12:29, Jason Wang wrote: > On 08/20/2014 05:23 PM, Zhangjie (HZ) wrote: >> On 2014/8/19 12:56, Jason Wang wrote: >>> commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue >> call it before setting >>> Zhang Jie, please test this patch to see if it fixes the issue. >>> +st

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-20 Thread Jason Wang
On 08/20/2014 05:23 PM, Zhangjie (HZ) wrote: > On 2014/8/19 12:56, Jason Wang wrote: >> commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue > call it before setting >> Zhang Jie, please test this patch to see if it fixes the issue. >> +static void vhost_net_set_vq_index(struct vhost_

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-20 Thread Michael S. Tsirkin
On Wed, Aug 20, 2014 at 12:18:33PM +0200, Michael S. Tsirkin wrote: > On Wed, Aug 20, 2014 at 05:23:21PM +0800, Zhangjie (HZ) wrote: > > On 2014/8/19 12:56, Jason Wang wrote: > > > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue > > call it before setting > > > Zhang Jie, please

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-20 Thread Michael S. Tsirkin
On Wed, Aug 20, 2014 at 05:23:21PM +0800, Zhangjie (HZ) wrote: > On 2014/8/19 12:56, Jason Wang wrote: > > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue > call it before setting > > Zhang Jie, please test this patch to see if it fixes the issue. > > > +static void vhost_net_se

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-20 Thread Zhangjie (HZ)
On 2014/8/19 12:56, Jason Wang wrote: > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue call it before setting > Zhang Jie, please test this patch to see if it fixes the issue. > +static void vhost_net_set_vq_index(struct vhost_net *net, int vq_index) > +{ > +net->dev.vq_ind

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-20 Thread William Dauchy
On Aug19 12:56, Jason Wang wrote: > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue > support changed the order of stopping the device. Previously > vhost_dev_stop would disable backend and only afterwards, unset guest > notifiers. We now unset guest notifiers while vhost is still

[Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-18 Thread Jason Wang
commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue support changed the order of stopping the device. Previously vhost_dev_stop would disable backend and only afterwards, unset guest notifiers. We now unset guest notifiers while vhost is still active. This can lose interrupts causing