subject:"\[Qemu\-devel\] \[PATCH V3\] net\: don't use set\/get_pointer\(\) in set\/get_netdev\(\)"

Re: [Qemu-devel] [PATCH V3] net: don't use set/get_pointer() in set/get_netdev()

2014-12-19 Thread Stefan Hajnoczi

On Mon, Oct 13, 2014 at 01:16:37PM +0800, Jason Wang wrote: > Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue > support) tries to use set_pointer() and get_pointer() to set and get > NICPeers which is not a pointer defined in DEFINE_PROP_NETDEV. This > trick works but result a uncl

Re: [Qemu-devel] [PATCH V3] net: don't use set/get_pointer() in set/get_netdev()

2014-12-19 Thread Markus Armbruster

This one fell through the cracks, sorry. Jason Wang writes: > Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue > support) tries to use set_pointer() and get_pointer() to set and get > NICPeers which is not a pointer defined in DEFINE_PROP_NETDEV. This > trick works but result a u

[Qemu-devel] [PATCH V3] net: don't use set/get_pointer() in set/get_netdev()

2014-10-12 Thread Jason Wang

Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue support) tries to use set_pointer() and get_pointer() to set and get NICPeers which is not a pointer defined in DEFINE_PROP_NETDEV. This trick works but result a unclean and fragile implementation (e.g print_netdev and parse_netdev).