Re: [Qemu-devel] [PATCH V3] Target-arm: Add the Cortex-M4 CPU

2015-06-16 Thread Peter Maydell
On 16 June 2015 at 13:52, aurelio remonda wrote: > about the space between ARMCPU *cpu = ARM_CPU(obj); line and the first > set_feature, the cortex-m3 initfn does not have it, do you want me to > change that one too? Thanks I would leave that one alone. It's bad style, but fixing it should be a s

Re: [Qemu-devel] [PATCH V3] Target-arm: Add the Cortex-M4 CPU

2015-06-16 Thread aurelio remonda
about the space between ARMCPU *cpu = ARM_CPU(obj); line and the first set_feature, the cortex-m3 initfn does not have it, do you want me to change that one too? Thanks 2015-06-16 9:29 GMT-03:00 Liviu Ionescu : > >> On 16 Jun 2015, at 14:21, Peter Maydell wrote: >> >> >> ... I think we can >> get

Re: [Qemu-devel] [PATCH V3] Target-arm: Add the Cortex-M4 CPU

2015-06-16 Thread Liviu Ionescu
> On 16 Jun 2015, at 14:21, Peter Maydell wrote: > > > ... I think we can > get this into QEMU for 2.4. that would be really great, I have quite a lot of M4 MCUs in my Cortex-M branch. Liviu

Re: [Qemu-devel] [PATCH V3] Target-arm: Add the Cortex-M4 CPU

2015-06-16 Thread aurelio remonda
Thank you! Im working on it El 16/6/2015 8:21, "Peter Maydell" escribió: > On 15 June 2015 at 21:31, Aurelio C. Remonda > wrote: > > This patch adds the Cortex-M4 CPU. The M4 is basically the same as the > M3, > > the main differences being the DSP instructions and an optional FPU. > > OK, I've

Re: [Qemu-devel] [PATCH V3] Target-arm: Add the Cortex-M4 CPU

2015-06-16 Thread Peter Maydell
On 15 June 2015 at 21:31, Aurelio C. Remonda wrote: > This patch adds the Cortex-M4 CPU. The M4 is basically the same as the M3, > the main differences being the DSP instructions and an optional FPU. OK, I've checked through the v7M ARM ARM, and I'm happy that we don't need any further changes to

[Qemu-devel] [PATCH V3] Target-arm: Add the Cortex-M4 CPU

2015-06-15 Thread Aurelio C. Remonda
This patch adds the Cortex-M4 CPU. The M4 is basically the same as the M3, the main differences being the DSP instructions and an optional FPU. Created an ARM_FEATURE_THUMB_DSP to be added to any non-M thumb2-compatible CPU that uses DSP instructions, and manually added it to the M4 in its initfn.