Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board

2011-11-24 Thread Peter Maydell
On 24 November 2011 21:46, Andreas Färber wrote: > Am 24.11.2011 22:31, schrieb Peter Maydell: >> On 24 November 2011 20:19, Andreas Färber wrote: >>> Am 24.11.2011 20:41, schrieb Peter Maydell: On 22 November 2011 04:34, Peter Chubb wrote: > +obj-arm-y += imx_serial.o imx_timer.o imx_a

Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board

2011-11-24 Thread Andreas Färber
Am 24.11.2011 22:31, schrieb Peter Maydell: > On 24 November 2011 20:19, Andreas Färber wrote: >> Am 24.11.2011 20:41, schrieb Peter Maydell: >>> On 22 November 2011 04:34, Peter Chubb wrote: +obj-arm-y += imx_serial.o imx_timer.o imx_avic.o +obj-arm-y += kzm.o >>> >>> It would be bette

Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board

2011-11-24 Thread Peter Maydell
On 24 November 2011 20:19, Andreas Färber wrote: > Am 24.11.2011 20:41, schrieb Peter Maydell: >> On 22 November 2011 04:34, Peter Chubb wrote: >>> +obj-arm-y += imx_serial.o imx_timer.o imx_avic.o >>> +obj-arm-y += kzm.o >> >> It would be better to add the devices to the makefile in their >> cor

Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board

2011-11-24 Thread Andreas Färber
Am 24.11.2011 20:41, schrieb Peter Maydell: > On 22 November 2011 04:34, Peter Chubb wrote: >> +obj-arm-y += imx_serial.o imx_timer.o imx_avic.o >> +obj-arm-y += kzm.o > > It would be better to add the devices to the makefile in their > corresponding patches, I think. (Don't feel too strongly abo

Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board

2011-11-24 Thread Peter Maydell
On 22 November 2011 04:34, Peter Chubb wrote: > Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built > around the FreeScale i.MX31. This patch mostly looks OK to me. > +obj-arm-y += imx_serial.o imx_timer.o imx_avic.o > +obj-arm-y += kzm.o It would be better to add the device

Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board

2011-11-21 Thread Peter Chubb
Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built around the FreeScale i.MX31. Signed-off-by: Hans Jang Signed-off-by: Adam Clench Signed-off-by: Peter Chubb --- Makefile.target |2 hw/kzm.c| 155 2 fi