Re: [Qemu-devel] [PATCH V2] support access to more performance registers in AA64 mode

2014-12-08 Thread Peter Maydell
On 8 December 2014 at 20:14, Chengyu Song wrote: > Hello Peter, > >> Thanks for sending this patch. I've provided some detailed >> review below -- there are quite a lot of comments but the >> fixes needed are all very minor. > > I'm not very familiar with the CP emulation, especially the NO_MIGRAT

Re: [Qemu-devel] [PATCH V2] support access to more performance registers in AA64 mode

2014-12-08 Thread Chengyu Song
Hello Peter, > Thanks for sending this patch. I've provided some detailed > review below -- there are quite a lot of comments but the > fixes needed are all very minor. I'm not very familiar with the CP emulation, especially the NO_MIGRATE flag, so thank you very much for the comment. > In this

Re: [Qemu-devel] [PATCH V2] support access to more performance registers in AA64 mode

2014-12-08 Thread Peter Maydell
On 6 December 2014 at 21:01, Chengyu Song wrote: > In AA64 mode, certain system registers are access through MSR/MRS > instructions instead of MCR/MRC. This patch added more such registers: > > /* ARMv8 manual rev A.d, D7.4.10 */ > PMINTENCLR_EL1 > > /* ARMv8 manual rev A.d, D7.4.11 */ > PMINTENSE

[Qemu-devel] [PATCH V2] support access to more performance registers in AA64 mode

2014-12-06 Thread Chengyu Song
In AA64 mode, certain system registers are access through MSR/MRS instructions instead of MCR/MRC. This patch added more such registers: /* ARMv8 manual rev A.d, D7.4.10 */ PMINTENCLR_EL1 /* ARMv8 manual rev A.d, D7.4.11 */ PMINTENSET_EL1 /* ARMv8 manual rev A.d, D7.4.12 */ PMOVSCLR_EL0 /* ARM