Re: [Qemu-devel] [PATCH V15 5/5] tests: add a unit test for the vmgenid device.

2015-04-27 Thread Michael S. Tsirkin
On Mon, Apr 27, 2015 at 09:01:36AM -0600, Eric Blake wrote: > On 04/27/2015 05:19 AM, Gal Hammer wrote: > > Signed-off-by: Gal Hammer > > Subject line: Most commits do NOT end in a trailing '.'. It's less > obvious if there is a preference for starting commits with a capital > after the subject,

Re: [Qemu-devel] [PATCH V15 5/5] tests: add a unit test for the vmgenid device.

2015-04-27 Thread Eric Blake
On 04/27/2015 05:19 AM, Gal Hammer wrote: > Signed-off-by: Gal Hammer Subject line: Most commits do NOT end in a trailing '.'. It's less obvious if there is a preference for starting commits with a capital after the subject, but that seems to be the current prevailing trend. So I might have done:

[Qemu-devel] [PATCH V15 5/5] tests: add a unit test for the vmgenid device.

2015-04-27 Thread Gal Hammer
Signed-off-by: Gal Hammer --- tests/Makefile | 2 ++ tests/vmgenid-test.c | 44 2 files changed, 46 insertions(+) create mode 100644 tests/vmgenid-test.c diff --git a/tests/Makefile b/tests/Makefile index 55aa745..6e4905c 100644 --- a/tests/Ma