Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Paolo Bonzini
On 08/06/2015 17:41, Michael S. Tsirkin wrote: > > > Adding it by default for everyone still seems too aggressive. > > > We had a ton of pain with pvpanic exactly because of a > > > similar "can't hurt" approach. > > > > The ton of pain was due to enabling it in ACPI unconditionally. We can >

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2015 at 05:33:19PM +0200, Paolo Bonzini wrote: > > > On 08/06/2015 17:22, Michael S. Tsirkin wrote: > > On Mon, Jun 08, 2015 at 05:17:31PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 08/06/2015 17:01, Michael S. Tsirkin wrote: > >>> Are there applications that would actually use

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Paolo Bonzini
On 08/06/2015 17:22, Michael S. Tsirkin wrote: > On Mon, Jun 08, 2015 at 05:17:31PM +0200, Paolo Bonzini wrote: >> >> >> On 08/06/2015 17:01, Michael S. Tsirkin wrote: >>> Are there applications that would actually use this? For microsoft this >>> seems to be mostly driven by ActiveDirectory nee

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2015 at 06:28:23PM +0300, Gal Hammer wrote: > On 08/06/2015 18:22, Michael S. Tsirkin wrote: > >On Mon, Jun 08, 2015 at 05:17:31PM +0200, Paolo Bonzini wrote: > >> > >> > >>On 08/06/2015 17:01, Michael S. Tsirkin wrote: > >>>Are there applications that would actually use this? For

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Gal Hammer
On 08/06/2015 18:22, Michael S. Tsirkin wrote: On Mon, Jun 08, 2015 at 05:17:31PM +0200, Paolo Bonzini wrote: On 08/06/2015 17:01, Michael S. Tsirkin wrote: Are there applications that would actually use this? For microsoft this seems to be mostly driven by ActiveDirectory needs. It seems qu

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2015 at 05:17:31PM +0200, Paolo Bonzini wrote: > > > On 08/06/2015 17:01, Michael S. Tsirkin wrote: > > Are there applications that would actually use this? For microsoft this > > seems to be mostly driven by ActiveDirectory needs. > > It seems quite possible that applications so

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Paolo Bonzini
On 08/06/2015 17:01, Michael S. Tsirkin wrote: > Are there applications that would actually use this? For microsoft this > seems to be mostly driven by ActiveDirectory needs. > It seems quite possible that applications solve the problem > differently on Linux. I'm not aware of a different solut

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2015 at 02:58:54PM +0100, Daniel P. Berrange wrote: > On Mon, Jun 08, 2015 at 03:55:14PM +0200, Paolo Bonzini wrote: > > > > > > On 08/06/2015 15:52, Gal Hammer wrote: > > >>> 2. Is it possible to create a sysbus device using the "-device" command > > >>> line argument? I vaguely

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Gal Hammer
On 08/06/2015 16:58, Daniel P. Berrange wrote: On Mon, Jun 08, 2015 at 03:55:14PM +0200, Paolo Bonzini wrote: On 08/06/2015 15:52, Gal Hammer wrote: 2. Is it possible to create a sysbus device using the "-device" command line argument? I vaguely recall that it is not possible to do it and tha

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Paolo Bonzini
On 08/06/2015 16:00, Gal Hammer wrote: >> What is the command line option like? Is it "-global vmgenid.uuid=foo"? > > Yes. Right now it is a "-global" and I've been asked to change it to > -"device", which I remember couldn't be done back then. I don't think it's worth doing it now, either. P

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Gal Hammer
On 08/06/2015 16:55, Paolo Bonzini wrote: On 08/06/2015 15:52, Gal Hammer wrote: 2. Is it possible to create a sysbus device using the "-device" command line argument? I vaguely recall that it is not possible to do it and that's the reason that I specifically add the device in the pc init. I

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Daniel P. Berrange
On Mon, Jun 08, 2015 at 03:55:14PM +0200, Paolo Bonzini wrote: > > > On 08/06/2015 15:52, Gal Hammer wrote: > >>> 2. Is it possible to create a sysbus device using the "-device" command > >>> line argument? I vaguely recall that it is not possible to do it and > >>> that's the reason that I speci

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Paolo Bonzini
On 08/06/2015 15:52, Gal Hammer wrote: >>> 2. Is it possible to create a sysbus device using the "-device" command >>> line argument? I vaguely recall that it is not possible to do it and >>> that's the reason that I specifically add the device in the pc init. >> >> It's now possible, but it is s

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Gal Hammer
On 08/06/2015 16:43, Paolo Bonzini wrote: On 08/06/2015 15:42, Gal Hammer wrote: On 03/06/2015 19:37, Paolo Bonzini wrote: Since Michael said he'd merge this version, there's just one thing I would change. You can access the region only one byte at a time, and let the memory core fix endian

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Paolo Bonzini
On 08/06/2015 15:42, Gal Hammer wrote: > On 03/06/2015 19:37, Paolo Bonzini wrote: >> >> Since Michael said he'd merge this version, there's just one thing I >> would change. You can access the region only one byte at a time, and >> let the memory core fix endianness here: > > I've applied the

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Gal Hammer
On 03/06/2015 19:37, Paolo Bonzini wrote: Since Michael said he'd merge this version, there's just one thing I would change. You can access the region only one byte at a time, and let the memory core fix endianness here: I've applied the change offered below. Thanks. There are two unanswered

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-03 Thread Michael S. Tsirkin
On Fri, May 29, 2015 at 01:46:44PM +0200, Igor Mammedov wrote: > On Mon, 27 Apr 2015 14:19:50 +0300 > Gal Hammer wrote: > > > Based on Microsoft's sepecifications (paper can be dowloaded from > > http://go.microsoft.com/fwlink/?LinkId=260709), add a device > > description to the SSDT ACPI table a

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-03 Thread Paolo Bonzini
Since Michael said he'd merge this version, there's just one thing I would change. You can access the region only one byte at a time, and let the memory core fix endianness here: On 27/04/2015 13:19, Gal Hammer wrote: > +static uint64_t vmgenid_ram_read(void *opaque, hwaddr addr, > +

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-05-29 Thread Igor Mammedov
On Mon, 27 Apr 2015 14:19:50 +0300 Gal Hammer wrote: > Based on Microsoft's sepecifications (paper can be dowloaded from > http://go.microsoft.com/fwlink/?LinkId=260709), add a device > description to the SSDT ACPI table and its implementation. > > The GUID is set using a global "vmgenid.uuid" p

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-05-28 Thread Paolo Bonzini
On 28/05/2015 15:24, Michael S. Tsirkin wrote: > On Thu, May 28, 2015 at 03:00:52PM +0200, Paolo Bonzini wrote: >> >> >> On 28/05/2015 14:21, Michael S. Tsirkin wrote: And the way I can fix it would be...? Is there another memory region I can use? Thanks, Gal. >>

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-05-28 Thread Michael S. Tsirkin
On Thu, May 28, 2015 at 03:00:52PM +0200, Paolo Bonzini wrote: > > > On 28/05/2015 14:21, Michael S. Tsirkin wrote: > > > And the way I can fix it would be...? Is there another memory region I can > > > use? > > > > > > Thanks, > > > > > > Gal. > > > > I think we hammered out an interestin

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-05-28 Thread Paolo Bonzini
On 28/05/2015 14:21, Michael S. Tsirkin wrote: > > And the way I can fix it would be...? Is there another memory region I can > > use? > > > > Thanks, > > > > Gal. > > I think we hammered out an interesting alternative off-list: get hold of > some AddressRegionNVS memory and copy data from

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-05-28 Thread Michael S. Tsirkin
On Thu, May 28, 2015 at 02:59:09PM +0300, Gal Hammer wrote: > On 28/05/2015 13:25, Paolo Bonzini wrote: > > > > > >On 27/04/2015 13:19, Gal Hammer wrote: > >>+static void vmgenid_init(Object *obj) > >>+{ > >>+SysBusDevice *sbd = SYS_BUS_DEVICE(obj); > >>+VmGenIdState *s = VMGENID(obj); > >>

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-05-28 Thread Gal Hammer
On 28/05/2015 13:25, Paolo Bonzini wrote: On 27/04/2015 13:19, Gal Hammer wrote: +static void vmgenid_init(Object *obj) +{ +SysBusDevice *sbd = SYS_BUS_DEVICE(obj); +VmGenIdState *s = VMGENID(obj); + +memory_region_init_io(&s->iomem, obj, &vmgenid_ram_ops, s, "vgid", 16); This is

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-05-28 Thread Michael S. Tsirkin
On Thu, May 28, 2015 at 12:25:40PM +0200, Paolo Bonzini wrote: > > > On 27/04/2015 13:19, Gal Hammer wrote: > > +static void vmgenid_init(Object *obj) > > +{ > > +SysBusDevice *sbd = SYS_BUS_DEVICE(obj); > > +VmGenIdState *s = VMGENID(obj); > > + > > +memory_region_init_io(&s->iomem,

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-05-28 Thread Paolo Bonzini
On 27/04/2015 13:19, Gal Hammer wrote: > +static void vmgenid_init(Object *obj) > +{ > +SysBusDevice *sbd = SYS_BUS_DEVICE(obj); > +VmGenIdState *s = VMGENID(obj); > + > +memory_region_init_io(&s->iomem, obj, &vmgenid_ram_ops, s, "vgid", 16); This is a small problem. The spec says t

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-04-29 Thread Gal Hammer
On 27/04/2015 16:38, Michael S. Tsirkin wrote: On Mon, Apr 27, 2015 at 02:19:50PM +0300, Gal Hammer wrote: Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implementation. Th

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-04-27 Thread Eric Blake
On 04/27/2015 05:19 AM, Gal Hammer wrote: > Based on Microsoft's sepecifications (paper can be dowloaded from s/sepecifications/specifications/ s/dowloaded/downloaded/ > http://go.microsoft.com/fwlink/?LinkId=260709), add a device > description to the SSDT ACPI table and its implementation. > >

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-04-27 Thread Michael S. Tsirkin
On Mon, Apr 27, 2015 at 02:19:50PM +0300, Gal Hammer wrote: > Based on Microsoft's sepecifications (paper can be dowloaded from > http://go.microsoft.com/fwlink/?LinkId=260709), add a device > description to the SSDT ACPI table and its implementation. > > The GUID is set using a global "vmgenid.uu

[Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-04-27 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implementation. The GUID is set using a global "vmgenid.uuid" parameter. Signed-off-by: Gal Hammer --- default-configs/i386-s