Re: [Qemu-devel] [PATCH V12 6/7] libqblock API implement

2012-11-29 Thread Paolo Bonzini
Il 29/11/2012 07:25, Wenchao Xia ha scritto: >> >> How can this be called with libqb_global_data.init_flag == 1? >> > OK, I will remove the if, but keep init_flag which can show > library is already initialized. Please remove it if there is no usage elsewhere. For debugging, qemu_aio_context !=

Re: [Qemu-devel] [PATCH V12 6/7] libqblock API implement

2012-11-28 Thread Wenchao Xia
于 2012-11-28 17:17, Paolo Bonzini 写道: Almost there... Il 28/11/2012 09:55, Wenchao Xia ha scritto: +/* This file was only used in libqblock, codes are copied from main-loop.c, + iohandler.c, compatfd.c now, it may have different implemention in the future. +*/ No need for this comment. wi

Re: [Qemu-devel] [PATCH V12 6/7] libqblock API implement

2012-11-28 Thread Paolo Bonzini
Almost there... Il 28/11/2012 09:55, Wenchao Xia ha scritto: > +/* This file was only used in libqblock, codes are copied from main-loop.c, > + iohandler.c, compatfd.c now, it may have different implemention in the > future. > +*/ No need for this comment. > + > +/* Signal fd support, original

[Qemu-devel] [PATCH V12 6/7] libqblock API implement

2012-11-28 Thread Wenchao Xia
This patch contains implemention for APIs. Important APIs: 1 QBlockContext. This structure was used to retrieve errors, every thread must create one first. 2 QBlockImage. It stands for an block image object. 3 QBlockStaticInfo. It contains static information such as location, backing file,