Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-12 Thread Markus Armbruster
Wenchao Xia writes: > 于 2013-4-12 11:22, Eric Blake 写道: >> On 04/11/2013 09:17 PM, Wenchao Xia wrote: >> > Hmm, as I typed that, I did another search of qemu-schema.json - we have > the type 'ImageInfo' defined, but none of the existing 'command's ever > call out the use of that

Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-12 Thread Wenchao Xia
于 2013-4-12 11:22, Eric Blake 写道: On 04/11/2013 09:17 PM, Wenchao Xia wrote: Hmm, as I typed that, I did another search of qemu-schema.json - we have the type 'ImageInfo' defined, but none of the existing 'command's ever call out the use of that type. Is it a type we are only using internall

Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-11 Thread Eric Blake
On 04/11/2013 09:17 PM, Wenchao Xia wrote: >> >>> Hmm, as I typed that, I did another search of qemu-schema.json - we have >>> the type 'ImageInfo' defined, but none of the existing 'command's ever >>> call out the use of that type. Is it a type we are only using >>> internally to date, and where

Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-11 Thread Wenchao Xia
于 2013-4-11 21:39, Luiz Capitulino 写道: On Thu, 11 Apr 2013 07:08:41 -0600 Eric Blake wrote: On 04/11/2013 06:44 AM, Luiz Capitulino wrote: +-> { "execute": "query-snapshots" } +<- { + "return":[ + { +"id": "1", +"name": "snapshot1", +"vm-state

Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-11 Thread Luiz Capitulino
On Thu, 11 Apr 2013 07:08:41 -0600 Eric Blake wrote: > On 04/11/2013 06:44 AM, Luiz Capitulino wrote: > > > +-> { "execute": "query-snapshots" } > > +<- { > > + "return":[ > > + { > > +"id": "1", > > +"name": "snapshot1", > > +

Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-11 Thread Eric Blake
On 04/11/2013 06:44 AM, Luiz Capitulino wrote: > +-> { "execute": "query-snapshots" } > +<- { > + "return":[ > + { > +"id": "1", > +"name": "snapshot1", > +"vm-state-size": 0, > +"date-sec": 1200,

Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-11 Thread Luiz Capitulino
On Thu, 11 Apr 2013 14:11:23 +0200 Markus Armbruster wrote: > Wenchao Xia writes: > > >>> # Statistics of a virtual block device or a block backing device. > >>> diff --git a/qmp-commands.hx b/qmp-commands.hx > >>> index 1e0e11e..6b20684 100644 > >>> --- a/qmp-commands.hx > >>> +++ b/qmp-comm

Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-11 Thread Markus Armbruster
Wenchao Xia writes: >>> # Statistics of a virtual block device or a block backing device. >>> diff --git a/qmp-commands.hx b/qmp-commands.hx >>> index 1e0e11e..6b20684 100644 >>> --- a/qmp-commands.hx >>> +++ b/qmp-commands.hx >>> @@ -1765,6 +1765,61 @@ EQMP >>> }, >>> >>> SQMP >>> +

Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-10 Thread Wenchao Xia
>> # Statistics of a virtual block device or a block backing device. >> diff --git a/qmp-commands.hx b/qmp-commands.hx >> index 1e0e11e..6b20684 100644 >> --- a/qmp-commands.hx >> +++ b/qmp-commands.hx >> @@ -1765,6 +1765,61 @@ EQMP >> }, >> >> SQMP >> +query-snapshots >> +---

Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-10 Thread Markus Armbruster
Wenchao Xia writes: > This interface returns info of valid internal snapshots for whole vm. > > Signed-off-by: Wenchao Xia > Reviewed-by: Eric Blake > Reviewed-by: Kevin Wolf > --- > block/qapi.c | 17 > qapi-schema.json | 14 + > qmp-commands.hx | 55

Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-08 Thread Stefan Hajnoczi
On Tue, Apr 02, 2013 at 07:47:22PM +0800, Wenchao Xia wrote: > diff --git a/qmp-commands.hx b/qmp-commands.hx > index 1e0e11e..6b20684 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -1765,6 +1765,61 @@ EQMP > }, > > SQMP > +query-snapshots > +--- > + > +Show the int

[Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-02 Thread Wenchao Xia
This interface returns info of valid internal snapshots for whole vm. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf --- block/qapi.c | 17 qapi-schema.json | 14 + qmp-commands.hx | 55 ++