Re: [Qemu-devel] [PATCH V10 4/7] libqblock build system

2012-11-21 Thread Wenchao Xia
于 2012-11-21 15:56, Paolo Bonzini 写道: Il 21/11/2012 04:03, Wenchao Xia ha scritto: +libqblock="yes" Please make the default the empty string, i.e. "build if and only if libtool is present". Do you mean adding a probe section later that if libtool is present, its default is "yes", else s

Re: [Qemu-devel] [PATCH V10 4/7] libqblock build system

2012-11-20 Thread Paolo Bonzini
Il 21/11/2012 04:03, Wenchao Xia ha scritto: >> >>> +libqblock="yes" >> >> Please make the default the empty string, i.e. "build if and only if >> libtool is present". >> > Do you mean adding a probe section later that if libtool is present, > its default is "yes", else set it to "no"? Here, you

Re: [Qemu-devel] [PATCH V10 4/7] libqblock build system

2012-11-20 Thread Wenchao Xia
于 2012-11-20 18:26, Paolo Bonzini 写道: Mostly looks good... Il 20/11/2012 10:46, Wenchao Xia ha scritto: +libqblock="yes" Please make the default the empty string, i.e. "build if and only if libtool is present". Do you mean adding a probe section later that if libtool is present, its defau

Re: [Qemu-devel] [PATCH V10 4/7] libqblock build system

2012-11-20 Thread Paolo Bonzini
Mostly looks good... Il 20/11/2012 10:46, Wenchao Xia ha scritto: > +libqblock="yes" Please make the default the empty string, i.e. "build if and only if libtool is present". > > +## > +# libqblock probe > +if test "$libqblock" != "no" ; then > +# libqblo

[Qemu-devel] [PATCH V10 4/7] libqblock build system

2012-11-20 Thread Wenchao Xia
Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related source code will generate 3 sets of binary, first is old ones used in qemu, second and third are non PIC and PIC ones in ./libqblock. GCC