Re: [Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI

2012-12-03 Thread Peter Maydell
On 3 December 2012 13:37, Gerd Hoffmann wrote: >> But why both EHCI controller are named "usb-bus.0"? How to distinguish the >> different usb usb? > > That is the default name. For usb controllers added via -device the bus > name is derived from the device name, i.e. '-device usb-ehci,id=ehci" >

Re: [Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI

2012-12-03 Thread Gerd Hoffmann
Hi, >>> Qemu doesn't provide some properties, such as "bus", to specify which EHCI >>> controller the >>> usb device attach to. If we use "device" and "usb-storage", we never >>> attach the usb >>> device to the specified EHCI controller. >> >> -device certainly ought to let you specify a bus

Re: [Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI

2012-12-03 Thread walimis
On Mon, Dec 03, 2012 at 12:10:02PM +, Peter Maydell wrote: >On 3 December 2012 11:58, walimis wrote: >> For example, xilinx_zynq has two EHCI controllers. If I specify a usb >> device of type "usb-storage", the question is: which EHCI controller does the >> usb device attach to? The answer is

Re: [Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI

2012-12-03 Thread Peter Maydell
On 3 December 2012 11:58, walimis wrote: > For example, xilinx_zynq has two EHCI controllers. If I specify a usb > device of type "usb-storage", the question is: which EHCI controller does the > usb device attach to? The answer is dependent. > > 1. If I use "usbdevice" and pass the host usb device

Re: [Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI

2012-12-03 Thread walimis
On Mon, Dec 03, 2012 at 07:59:55AM +0100, Gerd Hoffmann wrote: > Hi, > >> Gerd: In order for me to use this with the new-style Tegra2 model we >> will need to further move EHCISysBusState and the accompanying macros >> that this series adds into the hcd-ehci.h header so that it can be >> embedded

Re: [Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI

2012-12-02 Thread Gerd Hoffmann
Hi, > Gerd: In order for me to use this with the new-style Tegra2 model we > will need to further move EHCISysBusState and the accompanying macros > that this series adds into the hcd-ehci.h header so that it can be > embedded into the SoC object. So if you're okay with my approach we'd > need a

Re: [Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI

2012-12-02 Thread walimis
On Sun, Dec 02, 2012 at 05:27:16PM +0100, Andreas F鋜ber wrote: >Am 02.12.2012 11:34, schrieb walimis: >> On Sun, Dec 02, 2012 at 03:57:17AM +0100, Andreas F鋜ber wrote: >>> Appended is Liming's patch to add an EHCI device to Exynos 4 as well as a >>> new patch of mine to prepare a Tegra 2 EHCI devic

Re: [Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI

2012-12-02 Thread Andreas Färber
Am 02.12.2012 11:34, schrieb walimis: > On Sun, Dec 02, 2012 at 03:57:17AM +0100, Andreas Färber wrote: >> Appended is Liming's patch to add an EHCI device to Exynos 4 as well as a >> new patch of mine to prepare a Tegra 2 EHCI device (cf. my tegra branch) to > > BTW, where can I find your tegra b

Re: [Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI

2012-12-02 Thread walimis
On Sun, Dec 02, 2012 at 03:57:17AM +0100, Andreas Färber wrote: >Hello, > >Some review comments for SysBus EHCI were ignored in favor of merging into 1.3. >As requested by Gerd, this now follows up with the cleanups I had requested >from Peter C. Apart from using the new-style QOM casts it also ach

[Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI

2012-12-01 Thread Andreas Färber
Hello, Some review comments for SysBus EHCI were ignored in favor of merging into 1.3. As requested by Gerd, this now follows up with the cleanups I had requested from Peter C. Apart from using the new-style QOM casts it also achieves some deduplification. It then goes on to implement the suggeste