Re: [Qemu-devel] [PATCH RFC v5 1/7] Fix segmentation fault when qemu_signal_init fails

2018-10-18 Thread Fei Li
Kindly ping. :) Main discuss whether adding the Error for qemu_thread_create() or not. For details, please see blow: On 10/17/2018 04:17 PM, Fei Li wrote: Sorry for the late reply! Omitted this one.. On 10/12/2018 09:26 PM, Markus Armbruster wrote: Fei Li writes: On 10/12/2018 03:56 PM, M

Re: [Qemu-devel] [PATCH RFC v5 1/7] Fix segmentation fault when qemu_signal_init fails

2018-10-17 Thread Fei Li
Sorry for the late reply! Omitted this one.. On 10/12/2018 09:26 PM, Markus Armbruster wrote: Fei Li writes: On 10/12/2018 03:56 PM, Markus Armbruster wrote: Fei Li writes: On 10/11/2018 06:02 PM, Markus Armbruster wrote: Fei Li writes: Currently, when qemu_signal_init() fails it onl

Re: [Qemu-devel] [PATCH RFC v5 1/7] Fix segmentation fault when qemu_signal_init fails

2018-10-12 Thread Markus Armbruster
Fei Li writes: > On 10/12/2018 03:56 PM, Markus Armbruster wrote: >> Fei Li writes: >> >>> On 10/11/2018 06:02 PM, Markus Armbruster wrote: Fei Li writes: > Currently, when qemu_signal_init() fails it only returns a non-zero > value but without propagating any Error. But its c

Re: [Qemu-devel] [PATCH RFC v5 1/7] Fix segmentation fault when qemu_signal_init fails

2018-10-12 Thread Fei Li
On 10/12/2018 03:56 PM, Markus Armbruster wrote: Fei Li writes: On 10/11/2018 06:02 PM, Markus Armbruster wrote: Fei Li writes: Currently, when qemu_signal_init() fails it only returns a non-zero value but without propagating any Error. But its callers need a non-null err when runs erro

Re: [Qemu-devel] [PATCH RFC v5 1/7] Fix segmentation fault when qemu_signal_init fails

2018-10-12 Thread Markus Armbruster
Fei Li writes: > On 10/11/2018 06:02 PM, Markus Armbruster wrote: >> Fei Li writes: >> >>> Currently, when qemu_signal_init() fails it only returns a non-zero >>> value but without propagating any Error. But its callers need a >>> non-null err when runs error_report_err(err), or else 0->msg occu

Re: [Qemu-devel] [PATCH RFC v5 1/7] Fix segmentation fault when qemu_signal_init fails

2018-10-11 Thread Fei Li
On 10/11/2018 06:02 PM, Markus Armbruster wrote: Fei Li writes: Currently, when qemu_signal_init() fails it only returns a non-zero value but without propagating any Error. But its callers need a non-null err when runs error_report_err(err), or else 0->msg occurs. The bug is in qemu_init_m

Re: [Qemu-devel] [PATCH RFC v5 1/7] Fix segmentation fault when qemu_signal_init fails

2018-10-11 Thread Markus Armbruster
Fei Li writes: > Currently, when qemu_signal_init() fails it only returns a non-zero > value but without propagating any Error. But its callers need a > non-null err when runs error_report_err(err), or else 0->msg occurs. The bug is in qemu_init_main_loop(): ret = qemu_signal_init(); if

[Qemu-devel] [PATCH RFC v5 1/7] Fix segmentation fault when qemu_signal_init fails

2018-10-10 Thread Fei Li
Currently, when qemu_signal_init() fails it only returns a non-zero value but without propagating any Error. But its callers need a non-null err when runs error_report_err(err), or else 0->msg occurs. To avoid such segmentation fault, add a new Error parameter to make the call trace to propagate t