Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-24 Thread Jason Wang
On 2017年01月25日 09:31, Alex Williamson wrote: On Wed, 25 Jan 2017 09:19:25 +0800 Jason Wang wrote: On 2017年01月24日 03:40, Alex Williamson wrote: On Mon, 23 Jan 2017 18:23:44 +0800 Jason Wang wrote: On 2017年01月23日 11:34, Peter Xu wrote: On Mon, Jan 23, 2017 at 09:55:39AM +0800, Jason Wan

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-24 Thread Peter Xu
On Tue, Jan 24, 2017 at 09:24:29AM -0700, Alex Williamson wrote: [...] > > I see. Then this will be an strict requirement that we cannot do > > coalescing during page walk, at least for mappings. > > > > I didn't notice this before, but luckily current series is following > > the rule above - we

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-24 Thread Alex Williamson
On Wed, 25 Jan 2017 09:19:25 +0800 Jason Wang wrote: > On 2017年01月24日 03:40, Alex Williamson wrote: > > On Mon, 23 Jan 2017 18:23:44 +0800 > > Jason Wang wrote: > > > >> On 2017年01月23日 11:34, Peter Xu wrote: > >>> On Mon, Jan 23, 2017 at 09:55:39AM +0800, Jason Wang wrote: > On 2017年0

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-24 Thread Jason Wang
On 2017年01月24日 03:40, Alex Williamson wrote: On Mon, 23 Jan 2017 18:23:44 +0800 Jason Wang wrote: On 2017年01月23日 11:34, Peter Xu wrote: On Mon, Jan 23, 2017 at 09:55:39AM +0800, Jason Wang wrote: On 2017年01月22日 17:04, Peter Xu wrote: On Sun, Jan 22, 2017 at 04:08:04PM +0800, Jason Wang wr

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-24 Thread Alex Williamson
On Tue, 24 Jan 2017 15:22:15 +0800 Peter Xu wrote: > On Mon, Jan 23, 2017 at 11:03:08AM -0700, Alex Williamson wrote: > > On Mon, 23 Jan 2017 11:34:29 +0800 > > Peter Xu wrote: > > > > > On Mon, Jan 23, 2017 at 09:55:39AM +0800, Jason Wang wrote: > > > > > > > > > > > > On 2017年01月22日 17:

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-23 Thread Peter Xu
On Mon, Jan 23, 2017 at 11:03:08AM -0700, Alex Williamson wrote: > On Mon, 23 Jan 2017 11:34:29 +0800 > Peter Xu wrote: > > > On Mon, Jan 23, 2017 at 09:55:39AM +0800, Jason Wang wrote: > > > > > > > > > On 2017年01月22日 17:04, Peter Xu wrote: > > > >On Sun, Jan 22, 2017 at 04:08:04PM +0800, Ja

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-23 Thread Peter Xu
On Mon, Jan 23, 2017 at 06:23:44PM +0800, Jason Wang wrote: > > > On 2017年01月23日 11:34, Peter Xu wrote: > >On Mon, Jan 23, 2017 at 09:55:39AM +0800, Jason Wang wrote: > >> > >>On 2017年01月22日 17:04, Peter Xu wrote: > >>>On Sun, Jan 22, 2017 at 04:08:04PM +0800, Jason Wang wrote: > >>> > >>>[...] >

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-23 Thread Alex Williamson
On Mon, 23 Jan 2017 18:23:44 +0800 Jason Wang wrote: > On 2017年01月23日 11:34, Peter Xu wrote: > > On Mon, Jan 23, 2017 at 09:55:39AM +0800, Jason Wang wrote: > >> > >> On 2017年01月22日 17:04, Peter Xu wrote: > >>> On Sun, Jan 22, 2017 at 04:08:04PM +0800, Jason Wang wrote: > >>> > >>> [...] > >>

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-23 Thread Alex Williamson
On Mon, 23 Jan 2017 11:34:29 +0800 Peter Xu wrote: > On Mon, Jan 23, 2017 at 09:55:39AM +0800, Jason Wang wrote: > > > > > > On 2017年01月22日 17:04, Peter Xu wrote: > > >On Sun, Jan 22, 2017 at 04:08:04PM +0800, Jason Wang wrote: > > > > > >[...] > > > > > >>>+static void vtd_iotlb_page_inval

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-23 Thread Jason Wang
On 2017年01月23日 11:40, Peter Xu wrote: On Mon, Jan 23, 2017 at 10:01:11AM +0800, Jason Wang wrote: On 2017年01月20日 21:08, Peter Xu wrote: This patch is based on Aviv Ben-David ()'s patch upstream: "IOMMU: enable intel_iommu map and unmap notifiers" https://lists.gnu.org/archive/html/qem

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-23 Thread Jason Wang
On 2017年01月23日 11:34, Peter Xu wrote: On Mon, Jan 23, 2017 at 09:55:39AM +0800, Jason Wang wrote: On 2017年01月22日 17:04, Peter Xu wrote: On Sun, Jan 22, 2017 at 04:08:04PM +0800, Jason Wang wrote: [...] +static void vtd_iotlb_page_invalidate_notify(IntelIOMMUState *s, +

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-22 Thread Peter Xu
On Mon, Jan 23, 2017 at 10:01:11AM +0800, Jason Wang wrote: > > > On 2017年01月20日 21:08, Peter Xu wrote: > >This patch is based on Aviv Ben-David ()'s patch > >upstream: > > > > "IOMMU: enable intel_iommu map and unmap notifiers" > > https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg014

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-22 Thread Peter Xu
On Mon, Jan 23, 2017 at 09:55:39AM +0800, Jason Wang wrote: > > > On 2017年01月22日 17:04, Peter Xu wrote: > >On Sun, Jan 22, 2017 at 04:08:04PM +0800, Jason Wang wrote: > > > >[...] > > > >>>+static void vtd_iotlb_page_invalidate_notify(IntelIOMMUState *s, > >>>+

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-22 Thread Jason Wang
On 2017年01月23日 10:01, Jason Wang wrote: On 2017年01月20日 21:08, Peter Xu wrote: This patch is based on Aviv Ben-David ()'s patch upstream: "IOMMU: enable intel_iommu map and unmap notifiers" https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01453.html However I removed/fixed some con

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-22 Thread Jason Wang
On 2017年01月20日 21:08, Peter Xu wrote: This patch is based on Aviv Ben-David ()'s patch upstream: "IOMMU: enable intel_iommu map and unmap notifiers" https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01453.html However I removed/fixed some content, and added my own codes. Instead

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-22 Thread Jason Wang
On 2017年01月22日 17:04, Peter Xu wrote: On Sun, Jan 22, 2017 at 04:08:04PM +0800, Jason Wang wrote: [...] +static void vtd_iotlb_page_invalidate_notify(IntelIOMMUState *s, + uint16_t domain_id, hwaddr addr, + u

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-22 Thread Peter Xu
On Sun, Jan 22, 2017 at 04:08:04PM +0800, Jason Wang wrote: [...] > >+static void vtd_iotlb_page_invalidate_notify(IntelIOMMUState *s, > >+ uint16_t domain_id, hwaddr addr, > >+ uint8_t am) > >+{ > >+IntelIOMM

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-22 Thread Jason Wang
On 2017年01月20日 21:08, Peter Xu wrote: This patch is based on Aviv Ben-David ()'s patch upstream: "IOMMU: enable intel_iommu map and unmap notifiers" https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01453.html However I removed/fixed some content, and added my own codes. Instead

[Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-20 Thread Peter Xu
This patch is based on Aviv Ben-David ()'s patch upstream: "IOMMU: enable intel_iommu map and unmap notifiers" https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01453.html However I removed/fixed some content, and added my own codes. Instead of translate() every page for iotlb invalid