Re: [Qemu-devel] [PATCH RFC v3 4/7] migration: fix the compression code

2018-09-22 Thread Fei Li
Sorry for the late reply. On 09/20/2018 01:33 PM, Peter Xu wrote: On Thu, Sep 20, 2018 at 01:06:21PM +0800, Fei Li wrote: On 09/20/2018 12:31 PM, Peter Xu wrote: On Wed, Sep 19, 2018 at 09:35:20PM +0800, Fei Li wrote: Add judgement in compress_threads_save_cleanup() to check whether the sta

Re: [Qemu-devel] [PATCH RFC v3 4/7] migration: fix the compression code

2018-09-19 Thread Peter Xu
On Thu, Sep 20, 2018 at 01:06:21PM +0800, Fei Li wrote: > > > On 09/20/2018 12:31 PM, Peter Xu wrote: > > On Wed, Sep 19, 2018 at 09:35:20PM +0800, Fei Li wrote: > > > Add judgement in compress_threads_save_cleanup() to check whether the > > > static CompressParam *comp_param has been allocated.

Re: [Qemu-devel] [PATCH RFC v3 4/7] migration: fix the compression code

2018-09-19 Thread Fei Li
On 09/20/2018 12:31 PM, Peter Xu wrote: On Wed, Sep 19, 2018 at 09:35:20PM +0800, Fei Li wrote: Add judgement in compress_threads_save_cleanup() to check whether the static CompressParam *comp_param has been allocated. If not, just return; or else Segmentation fault will occur when using the

Re: [Qemu-devel] [PATCH RFC v3 4/7] migration: fix the compression code

2018-09-19 Thread Peter Xu
On Wed, Sep 19, 2018 at 09:35:20PM +0800, Fei Li wrote: > Add judgement in compress_threads_save_cleanup() to check whether the > static CompressParam *comp_param has been allocated. If not, just > return; or else Segmentation fault will occur when using the > NULL comp_param's parameters in termin

[Qemu-devel] [PATCH RFC v3 4/7] migration: fix the compression code

2018-09-19 Thread Fei Li
Add judgement in compress_threads_save_cleanup() to check whether the static CompressParam *comp_param has been allocated. If not, just return; or else Segmentation fault will occur when using the NULL comp_param's parameters in terminate_compression_threads(). One test case can reproduce this erro