On Thu, Sep 20, 2018 at 12:46:39PM +0800, Fei Li wrote:
>
>
> On 09/20/2018 11:28 AM, Peter Xu wrote:
> > On Wed, Sep 19, 2018 at 09:35:17PM +0800, Fei Li wrote:
> > > Currently, when qemu_signal_init() fails it only returns a non-zero
> > > value but without propagating any Error. But its caller
On 09/20/2018 11:28 AM, Peter Xu wrote:
On Wed, Sep 19, 2018 at 09:35:17PM +0800, Fei Li wrote:
Currently, when qemu_signal_init() fails it only returns a non-zero
value but without propagating any Error. But its callers need a
non-null err when runs error_report_err(err), or else 0->msg occu
On 09/19/2018 10:49 PM, Fam Zheng wrote:
On Wed, 09/19 21:35, Fei Li wrote:
Currently, when qemu_signal_init() fails it only returns a non-zero
value but without propagating any Error. But its callers need a
non-null err when runs error_report_err(err), or else 0->msg occurs.
To avoid such s
On Wed, Sep 19, 2018 at 09:35:17PM +0800, Fei Li wrote:
> Currently, when qemu_signal_init() fails it only returns a non-zero
> value but without propagating any Error. But its callers need a
> non-null err when runs error_report_err(err), or else 0->msg occurs.
>
> To avoid such segmentation faul
On Wed, 09/19 21:35, Fei Li wrote:
> Currently, when qemu_signal_init() fails it only returns a non-zero
> value but without propagating any Error. But its callers need a
> non-null err when runs error_report_err(err), or else 0->msg occurs.
>
> To avoid such segmentation fault, add a new Error pa
Currently, when qemu_signal_init() fails it only returns a non-zero
value but without propagating any Error. But its callers need a
non-null err when runs error_report_err(err), or else 0->msg occurs.
To avoid such segmentation fault, add a new Error parameter to make
the call trace to propagate t
