Re: [Qemu-devel] [PATCH RFC v2 4/9] rbd: Clean up after the previous commit

2017-03-24 Thread Eric Blake
On 03/24/2017 12:44 PM, Markus Armbruster wrote: > This code in qemu_rbd_parse_filename() > > found_str = qemu_rbd_next_tok(p, '\0', &p); This says to take a string starting at p, modify it in place, update p to point past the delimiter (well, to nowhere since the delimiter of '\0' means it i

[Qemu-devel] [PATCH RFC v2 4/9] rbd: Clean up after the previous commit

2017-03-24 Thread Markus Armbruster
This code in qemu_rbd_parse_filename() found_str = qemu_rbd_next_tok(p, '\0', &p); p = found_str; has no effect. Drop it, and simplify qemu_rbd_next_tok(). Signed-off-by: Markus Armbruster --- block/rbd.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-)