Re: [Qemu-devel] [PATCH RFC v2 37/47] qapi: De-duplicate parameter list generation

2015-07-29 Thread Markus Armbruster
Eric Blake writes: > On 07/28/2015 05:15 AM, Markus Armbruster wrote: > >>> Yeah, avoiding line wraps consumes fewer source bytes (fewer runs of >>> spaces), but the space isn't being wasted by storing generated files in >>> git, nor does the C compiler care which layout we use. And honestly, >>

Re: [Qemu-devel] [PATCH RFC v2 37/47] qapi: De-duplicate parameter list generation

2015-07-28 Thread Eric Blake
On 07/28/2015 05:15 AM, Markus Armbruster wrote: >> Yeah, avoiding line wraps consumes fewer source bytes (fewer runs of >> spaces), but the space isn't being wasted by storing generated files in >> git, nor does the C compiler care which layout we use. And honestly, >> it's easier to spot change

Re: [Qemu-devel] [PATCH RFC v2 37/47] qapi: De-duplicate parameter list generation

2015-07-28 Thread Markus Armbruster
Eric Blake writes: > On 07/01/2015 02:22 PM, Markus Armbruster wrote: >> Generated qapi-event.[ch] lose line breaks. No change otherwise. > > For example, > > -void qapi_event_send_block_image_corrupted(const char *device, > - bool has_node_name, > -

Re: [Qemu-devel] [PATCH RFC v2 37/47] qapi: De-duplicate parameter list generation

2015-07-23 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: > Generated qapi-event.[ch] lose line breaks. No change otherwise. For example, -void qapi_event_send_block_image_corrupted(const char *device, - bool has_node_name, -

[Qemu-devel] [PATCH RFC v2 37/47] qapi: De-duplicate parameter list generation

2015-07-01 Thread Markus Armbruster
Generated qapi-event.[ch] lose line breaks. No change otherwise. Signed-off-by: Markus Armbruster --- scripts/qapi-commands.py | 11 ++- scripts/qapi-event.py| 18 +++--- scripts/qapi.py | 16 3 files changed, 21 insertions(+), 24 deletions(-)