Re: [Qemu-devel] [PATCH RFC v2 2/5] tests: New make target check-source

2016-06-28 Thread Peter Maydell
On 28 June 2016 at 09:19, Markus Armbruster wrote: > Peter Maydell writes: > >> On 27 June 2016 at 07:34, Markus Armbruster wrote: >>> Peter Maydell writes: This is third-party code. We're not going to change it, so we should avoid scanning it rather than adding tags which will g

Re: [Qemu-devel] [PATCH RFC v2 2/5] tests: New make target check-source

2016-06-28 Thread Markus Armbruster
Peter Maydell writes: > On 27 June 2016 at 07:34, Markus Armbruster wrote: >> Peter Maydell writes: >>> This is third-party code. We're not going to change it, so >>> we should avoid scanning it rather than adding tags which >>> will get lost next time we do an update to a new upstream >>> vers

Re: [Qemu-devel] [PATCH RFC v2 2/5] tests: New make target check-source

2016-06-27 Thread Peter Maydell
On 27 June 2016 at 07:34, Markus Armbruster wrote: > Peter Maydell writes: >> This is third-party code. We're not going to change it, so >> we should avoid scanning it rather than adding tags which >> will get lost next time we do an update to a new upstream >> version... > > I can revive v1's bl

Re: [Qemu-devel] [PATCH RFC v2 2/5] tests: New make target check-source

2016-06-26 Thread Markus Armbruster
Peter Maydell writes: > On 24 June 2016 at 15:19, Markus Armbruster wrote: >> For now, this tests just a bit of header sanity: for each header >> "FOO.h", test whether >> >> #include "qemu/osdep.h" >> #include "FOO.h" >> #include "FOO.h" >> >> compiles. A large number of

Re: [Qemu-devel] [PATCH RFC v2 2/5] tests: New make target check-source

2016-06-24 Thread Peter Maydell
On 24 June 2016 at 15:19, Markus Armbruster wrote: > For now, this tests just a bit of header sanity: for each header > "FOO.h", test whether > > #include "qemu/osdep.h" > #include "FOO.h" > #include "FOO.h" > > compiles. A large number of headers don't pass this test, by