Re: [Qemu-devel] [PATCH RFC qom-cpu-next] apic: QOM'ify APICCommonState casts

2013-04-29 Thread Andreas Färber
Am 29.04.2013 12:29, schrieb Igor Mammedov: > On Sun, 28 Apr 2013 13:22:10 +0200 > Andreas Färber wrote: > >> Necessary to change the name of ICCDevice's parent object field. >> >> Signed-off-by: Andreas Färber >> --- >> Could any of the APIC experts please review whether I'm touching any hot

Re: [Qemu-devel] [PATCH RFC qom-cpu-next] apic: QOM'ify APICCommonState casts

2013-04-29 Thread Igor Mammedov
On Sun, 28 Apr 2013 13:22:10 +0200 Andreas Färber wrote: > Necessary to change the name of ICCDevice's parent object field. > > Signed-off-by: Andreas Färber > --- > Could any of the APIC experts please review whether I'm touching any hot > path? > Not sure if this was a mix of pre- and post

Re: [Qemu-devel] [PATCH RFC qom-cpu-next] apic: QOM'ify APICCommonState casts

2013-04-28 Thread Jan Kiszka
On 2013-04-28 15:53, Andreas Färber wrote: > Am 28.04.2013 15:03, schrieb Jan Kiszka: >> On 2013-04-28 13:22, Andreas Färber wrote: >>> Necessary to change the name of ICCDevice's parent object field. >>> >>> Signed-off-by: Andreas Färber --- Could any of >>> the APIC experts please review whether

Re: [Qemu-devel] [PATCH RFC qom-cpu-next] apic: QOM'ify APICCommonState casts

2013-04-28 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 28.04.2013 15:03, schrieb Jan Kiszka: > On 2013-04-28 13:22, Andreas Färber wrote: >> Necessary to change the name of ICCDevice's parent object field. >> >> Signed-off-by: Andreas Färber --- Could any of >> the APIC experts please review whether I

Re: [Qemu-devel] [PATCH RFC qom-cpu-next] apic: QOM'ify APICCommonState casts

2013-04-28 Thread Jan Kiszka
On 2013-04-28 13:22, Andreas Färber wrote: > Necessary to change the name of ICCDevice's parent object field. > > Signed-off-by: Andreas Färber > --- > Could any of the APIC experts please review whether I'm touching any hot > path? > Not sure if this was a mix of pre- and post-QOM code or int

[Qemu-devel] [PATCH RFC qom-cpu-next] apic: QOM'ify APICCommonState casts

2013-04-28 Thread Andreas Färber
Necessary to change the name of ICCDevice's parent object field. Signed-off-by: Andreas Färber --- Could any of the APIC experts please review whether I'm touching any hot path? Not sure if this was a mix of pre- and post-QOM code or intentional... Thanks. hw/i386/kvm/apic.c | 4 ++--