Re: [Qemu-devel] [PATCH RFC qom-cpu] linux-user: Avoid conditional cpu_reset()

2013-07-10 Thread Eduardo Habkost
On Wed, Jul 10, 2013 at 07:51:32PM +0100, Peter Maydell wrote: > On 10 July 2013 19:43, Eduardo Habkost wrote: > > On Wed, Jul 10, 2013 at 06:30:38PM +0200, Andreas Färber wrote: > >> Some CPUs reset as part of cpu_init(), some others were reset > >> afterwards, some not at all. While some targets

Re: [Qemu-devel] [PATCH RFC qom-cpu] linux-user: Avoid conditional cpu_reset()

2013-07-10 Thread Eduardo Habkost
On Wed, Jul 10, 2013 at 06:30:38PM +0200, Andreas Färber wrote: > Some CPUs reset as part of cpu_init(), some others were reset > afterwards, some not at all. While some targets didn't implement a > cpu_[state_]reset() function, QOM cpu_reset() is always available. > There's nothing wrong with rese

Re: [Qemu-devel] [PATCH RFC qom-cpu] linux-user: Avoid conditional cpu_reset()

2013-07-10 Thread Peter Maydell
On 10 July 2013 19:43, Eduardo Habkost wrote: > On Wed, Jul 10, 2013 at 06:30:38PM +0200, Andreas Färber wrote: >> Some CPUs reset as part of cpu_init(), some others were reset >> afterwards, some not at all. While some targets didn't implement a >> cpu_[state_]reset() function, QOM cpu_reset() is

[Qemu-devel] [PATCH RFC qom-cpu] linux-user: Avoid conditional cpu_reset()

2013-07-10 Thread Andreas Färber
Some CPUs reset as part of cpu_init(), some others were reset afterwards, some not at all. While some targets didn't implement a cpu_[state_]reset() function, QOM cpu_reset() is always available. There's nothing wrong with resetting twice on startup, so drop the #ifdef. Suggested-by: Peter Maydell