Re: [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files

2015-10-22 Thread Pavel Fedin
Hello! Some more notes after more careful reviewing. Actually, i am working on v3 of live migration RFC, i will include some macros which will help you to integrate better. > -Original Message- > From: Shlomo Pongratz [mailto:shlomopongr...@gmail.com] > Sent: Tuesday, October 20, 2015

Re: [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files

2015-10-21 Thread Shlomo Pongratz
O.K. On Wednesday, October 21, 2015, Pavel Fedin wrote: > Hello! > > > Do you mean that in virt.c::create_gic I'll take the cpu's affinity from > the cpu's property and not directly from > > ARM_CPU(qemu_get_cpu(i))->mp_affinity > > I mean that you can do it in your GIC's realize function. And

Re: [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files

2015-10-21 Thread Pavel Fedin
Hello! > Do you mean that in virt.c::create_gic I'll take the cpu's affinity from the > cpu's property and not directly from > ARM_CPU(qemu_get_cpu(i))->mp_affinity I mean that you can do it in your GIC's realize function. And, even better, in arm_gicv3_common_realize(), because KVM GICv3 liv

Re: [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files

2015-10-21 Thread Pavel Fedin
Hello! >> See this: >> http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg02349.html. This >> is also a part of my live migration RFC. >> I remember that Peter told long time ago that "it should really be a >> property", when i integrated full affinity support. But, he currently >> ref

Re: [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files

2015-10-21 Thread Shlomo Pongratz
See inline On Wednesday, October 21, 2015, Pavel Fedin wrote: > Hello! > > >> See this: > http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg02349.html. > This is also a part of my live migration RFC. > >> I remember that Peter told long time ago that "it should really be a > property",

Re: [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files

2015-10-21 Thread Shlomo Pongratz
See inline. On Wednesday, October 21, 2015, Pavel Fedin wrote: > Hello! > > > I can't find the patch that handles the for example modification of > "uint8_t sgi_pending[GIC_NR_SGIS][GIC_NCPU]" to fixed-size bitmaps. as > > GIC_NCPU is not a constant and uint8_t need to have the size of nubmer >

Re: [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files

2015-10-21 Thread Pavel Fedin
Hello! > I can't find the patch that handles the for example modification of "uint8_t > sgi_pending[GIC_NR_SGIS][GIC_NCPU]" to fixed-size bitmaps. as > GIC_NCPU is not a constant and uint8_t need to have the size of nubmer of > CPUs which is no longer bounded. This is the only thing which i e

Re: [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files

2015-10-20 Thread Pavel Fedin
Hello! > -Original Message- > From: Shlomo Pongratz [mailto:shlomopongr...@gmail.com] > Sent: Wednesday, October 21, 2015 6:09 AM > To: qemu-devel@nongnu.org > Cc: p.fe...@samsung.com; peter.mayd...@linaro.org; eric.au...@linaro.org; > shannon.z...@linaro.org; imamm...@redhat.com; ash...@