Re: [Qemu-devel] [PATCH RFC 6/8] exec: Clean up unnecessary S390 ifdeffery

2013-06-15 Thread Paolo Bonzini
Il 14/06/2013 04:06, Markus Armbruster ha scritto: > Here's another way to keep the KVM hooks regular: make my function > pointers exec.c hooks instead of KVM hooks ;-P I can buy this one! Paolo

Re: [Qemu-devel] [PATCH RFC 6/8] exec: Clean up unnecessary S390 ifdeffery

2013-06-14 Thread Markus Armbruster
Paolo Bonzini writes: > Il 13/06/2013 03:02, Markus Armbruster ha scritto: >> +} else if (kvm_enabled() && kvm_arch_ram_alloc) { >> +/* some s390/kvm configurations have special constraints */ >> +if (mem_path) { >> +fprintf(stderr, >> +"-mem-pa

Re: [Qemu-devel] [PATCH RFC 6/8] exec: Clean up unnecessary S390 ifdeffery

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 03:02, Markus Armbruster ha scritto: > +} else if (kvm_enabled() && kvm_arch_ram_alloc) { > +/* some s390/kvm configurations have special constraints */ > +if (mem_path) { > +fprintf(stderr, > +"-mem-path not supported with this vers

[Qemu-devel] [PATCH RFC 6/8] exec: Clean up unnecessary S390 ifdeffery

2013-06-13 Thread Markus Armbruster
Another issue missed in commit fdec991 is -mem-path: it needs to be rejected only for old S390 KVM, not for any S390. Not that I personally care, but the ifdeffery in qemu_ram_alloc_from_ptr() annoys me. Note that this doesn't actually make -mem-path work, as the kernel doesn't (yet?) support la