Re: [Qemu-devel] [PATCH RFC 4/8] target-arm: Avoid inline for get_phys_addr

2015-10-01 Thread Edgar E. Iglesias
On Wed, Sep 23, 2015 at 09:58:10AM -0700, Peter Maydell wrote: > On 19 September 2015 at 07:15, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > Avoid inline for get_phys_addr() to prepare for future recursive use. > > Does the compiler actually complain? Sorry for the late repl

Re: [Qemu-devel] [PATCH RFC 4/8] target-arm: Avoid inline for get_phys_addr

2015-09-23 Thread Peter Maydell
On 19 September 2015 at 07:15, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Avoid inline for get_phys_addr() to prepare for future recursive use. Does the compiler actually complain? In any case this function is a lot more complex than it used to be so we might as well just rely on

[Qemu-devel] [PATCH RFC 4/8] target-arm: Avoid inline for get_phys_addr

2015-09-19 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Avoid inline for get_phys_addr() to prepare for future recursive use. Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 6f0ed51..7e7f2