Re: [Qemu-devel] [PATCH RFC 3/6] qapi: rewrite string-input-visitor

2018-11-15 Thread Markus Armbruster
David Hildenbrand writes: > On 15.11.18 10:48, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> On 14.11.18 18:38, Markus Armbruster wrote: David Hildenbrand writes: > The input visitor has some problems right now, especially > - unsigned type "Range" is used to p

Re: [Qemu-devel] [PATCH RFC 3/6] qapi: rewrite string-input-visitor

2018-11-15 Thread David Hildenbrand
On 15.11.18 10:48, Markus Armbruster wrote: > David Hildenbrand writes: > >> On 14.11.18 18:38, Markus Armbruster wrote: >>> David Hildenbrand writes: >>> The input visitor has some problems right now, especially - unsigned type "Range" is used to process signed ranges, resulting in >>

Re: [Qemu-devel] [PATCH RFC 3/6] qapi: rewrite string-input-visitor

2018-11-15 Thread Markus Armbruster
David Hildenbrand writes: > On 14.11.18 18:38, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> The input visitor has some problems right now, especially >>> - unsigned type "Range" is used to process signed ranges, resulting in >>> inconsistent behavior and ugly/magical code >>>

Re: [Qemu-devel] [PATCH RFC 3/6] qapi: rewrite string-input-visitor

2018-11-14 Thread David Hildenbrand
On 14.11.18 18:38, Markus Armbruster wrote: > David Hildenbrand writes: > >> The input visitor has some problems right now, especially >> - unsigned type "Range" is used to process signed ranges, resulting in >> inconsistent behavior and ugly/magical code >> - uint64_t are parsed like int64_t,

Re: [Qemu-devel] [PATCH RFC 3/6] qapi: rewrite string-input-visitor

2018-11-14 Thread Markus Armbruster
David Hildenbrand writes: > The input visitor has some problems right now, especially > - unsigned type "Range" is used to process signed ranges, resulting in > inconsistent behavior and ugly/magical code > - uint64_t are parsed like int64_t, so big uint64_t values are not > supported and err

[Qemu-devel] [PATCH RFC 3/6] qapi: rewrite string-input-visitor

2018-11-09 Thread David Hildenbrand
The input visitor has some problems right now, especially - unsigned type "Range" is used to process signed ranges, resulting in inconsistent behavior and ugly/magical code - uint64_t are parsed like int64_t, so big uint64_t values are not supported and error messages are misleading - lists/ran