Re: [Qemu-devel] [PATCH RFC 2/6] qapi: use qemu_strtod() in string-input-visitor

2018-11-15 Thread Markus Armbruster
Eric Blake writes: > On 11/15/18 5:09 AM, David Hildenbrand wrote: > >>> Three more: in qobject-input-visitor.c's >>> qobject_input_type_number_keyval(), >> >> This one is interesting, as it properly bails out when parsing "inf" >> (via isFinite()). - should we do the same for the string input vi

Re: [Qemu-devel] [PATCH RFC 2/6] qapi: use qemu_strtod() in string-input-visitor

2018-11-15 Thread David Hildenbrand
On 15.11.18 14:17, Eric Blake wrote: > On 11/15/18 5:09 AM, David Hildenbrand wrote: > >>> Three more: in qobject-input-visitor.c's >>> qobject_input_type_number_keyval(), >> >> This one is interesting, as it properly bails out when parsing "inf" >> (via isFinite()). - should we do the same for th

Re: [Qemu-devel] [PATCH RFC 2/6] qapi: use qemu_strtod() in string-input-visitor

2018-11-15 Thread Eric Blake
On 11/15/18 5:09 AM, David Hildenbrand wrote: Three more: in qobject-input-visitor.c's qobject_input_type_number_keyval(), This one is interesting, as it properly bails out when parsing "inf" (via isFinite()). - should we do the same for the string input visitor? Especially, should we forbid

Re: [Qemu-devel] [PATCH RFC 2/6] qapi: use qemu_strtod() in string-input-visitor

2018-11-15 Thread David Hildenbrand
On 14.11.18 17:09, Markus Armbruster wrote: > David Hildenbrand writes: > >> Let's use the new function. >> >> Signed-off-by: David Hildenbrand >> --- >> qapi/string-input-visitor.c | 6 ++ >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/qapi/string-input-visitor.c b/q

Re: [Qemu-devel] [PATCH RFC 2/6] qapi: use qemu_strtod() in string-input-visitor

2018-11-14 Thread Markus Armbruster
David Hildenbrand writes: > Let's use the new function. > > Signed-off-by: David Hildenbrand > --- > qapi/string-input-visitor.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c > index b3fdd0827d..dee708d38

[Qemu-devel] [PATCH RFC 2/6] qapi: use qemu_strtod() in string-input-visitor

2018-11-09 Thread David Hildenbrand
Let's use the new function. Signed-off-by: David Hildenbrand --- qapi/string-input-visitor.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c index b3fdd0827d..dee708d384 100644 --- a/qapi/string-input-visitor.c +