Re: [Qemu-devel] [PATCH RFC 2/3] qemu-img: Add --unsafe-read option to subcommands

2017-04-19 Thread Fam Zheng
On Tue, 04/18 08:20, Eric Blake wrote: > bool, please. (Just because existing code is lousy with using an int > for a bool doesn't mean we should perpetuate it) OK, will fix. > > > > @@ -3033,6 +3085,9 @@ static int img_rebase(int argc, char **argv) > > case OPTION_IMAGE_OPTS: > >

Re: [Qemu-devel] [PATCH RFC 2/3] qemu-img: Add --unsafe-read option to subcommands

2017-04-18 Thread Eric Blake
On 03/13/2017 09:39 PM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > qemu-img.c | 148 > +++-- > 1 file changed, 114 insertions(+), 34 deletions(-) > > @@ -2711,9 +2751,10 @@ static int img_map(int argc, char **argv) >

[Qemu-devel] [PATCH RFC 2/3] qemu-img: Add --unsafe-read option to subcommands

2017-03-13 Thread Fam Zheng
Signed-off-by: Fam Zheng --- qemu-img.c | 148 +++-- 1 file changed, 114 insertions(+), 34 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 98b836b..3aaa254 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -273,12 +273,15 @@ static int im