Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-29 Thread Liu, Changpeng
u-bl...@nongnu.org; qemu-devel@nongnu.org; Max > Reitz ; Paolo Bonzini ; virtio- > comm...@lists.oasis-open.org > Subject: Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for > WRITE_ZEROES command > > On Sun, Jan 27, 2019 at 01:42:03PM -0500, Michael S. Tsirkin wrote: &g

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-29 Thread Stefan Hajnoczi
On Sun, Jan 27, 2019 at 01:42:03PM -0500, Michael S. Tsirkin wrote: > On Sun, Jan 27, 2019 at 12:57:20PM +, Stefan Hajnoczi wrote: > > On Fri, Jan 25, 2019 at 02:17:01PM -0500, Michael S. Tsirkin wrote: > > > On Fri, Jan 25, 2019 at 03:12:45PM +, Stefan Hajnoczi wrote: > > > > Based on the

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-27 Thread Michael S. Tsirkin
On Sun, Jan 27, 2019 at 12:57:20PM +, Stefan Hajnoczi wrote: > On Fri, Jan 25, 2019 at 02:17:01PM -0500, Michael S. Tsirkin wrote: > > On Fri, Jan 25, 2019 at 03:12:45PM +, Stefan Hajnoczi wrote: > > > Based on the Linux guest driver code and the lack of more evidence in > > > the spec, I'm

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-27 Thread Stefan Hajnoczi
On Fri, Jan 25, 2019 at 02:17:01PM -0500, Michael S. Tsirkin wrote: > On Fri, Jan 25, 2019 at 03:12:45PM +, Stefan Hajnoczi wrote: > > Based on the Linux guest driver code and the lack of more evidence in > > the spec, I'm pretty sure data[] doesn't need to be padded to 512 bytes > > for discar

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-25 Thread Michael S. Tsirkin
On Fri, Jan 25, 2019 at 03:12:45PM +, Stefan Hajnoczi wrote: > On Fri, Jan 25, 2019 at 09:49:03AM +0100, Thomas Huth wrote: > > On 2019-01-25 09:16, Stefano Garzarella wrote: > > > On Fri, Jan 25, 2019 at 07:07:35AM +0100, Thomas Huth wrote: > > >> On 2019-01-25 07:01, Thomas Huth wrote: > > >>

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-25 Thread Michael S. Tsirkin
On Fri, Jan 25, 2019 at 09:49:03AM +0100, Thomas Huth wrote: > On 2019-01-25 09:16, Stefano Garzarella wrote: > > On Fri, Jan 25, 2019 at 07:07:35AM +0100, Thomas Huth wrote: > >> On 2019-01-25 07:01, Thomas Huth wrote: > >>> On 2019-01-24 18:23, Stefano Garzarella wrote: > If the WRITE_ZEROES

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-25 Thread Michael S. Tsirkin
gt;> To: Stefano Garzarella ; Michael S. Tsirkin > >> ; Liu, Changpeng > >> Cc: qemu-devel@nongnu.org; Laurent Vivier ; Kevin Wolf > >> ; qemu-bl...@nongnu.org; Max Reitz > >> ; Stefan Hajnoczi ; Paolo Bonzini > >> > >> Subject: Re: [Qemu-deve

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-25 Thread Stefan Hajnoczi
On Fri, Jan 25, 2019 at 09:49:03AM +0100, Thomas Huth wrote: > On 2019-01-25 09:16, Stefano Garzarella wrote: > > On Fri, Jan 25, 2019 at 07:07:35AM +0100, Thomas Huth wrote: > >> On 2019-01-25 07:01, Thomas Huth wrote: > >>> On 2019-01-24 18:23, Stefano Garzarella wrote: > If the WRITE_ZEROES

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-25 Thread Thomas Huth
el@nongnu.org; Laurent Vivier ; Kevin Wolf >> ; qemu-bl...@nongnu.org; Max Reitz >> ; Stefan Hajnoczi ; Paolo Bonzini >> >> Subject: Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for >> WRITE_ZEROES command >> >> On 2019-01-25 09:16, Stefano Garzar

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-25 Thread Liu, Changpeng
z > ; Stefan Hajnoczi ; Paolo Bonzini > > Subject: Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for > WRITE_ZEROES command > > On 2019-01-25 09:16, Stefano Garzarella wrote: > > On Fri, Jan 25, 2019 at 07:07:35AM +0100, Thomas Huth wrote: > >> On 20

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-25 Thread Thomas Huth
On 2019-01-25 09:16, Stefano Garzarella wrote: > On Fri, Jan 25, 2019 at 07:07:35AM +0100, Thomas Huth wrote: >> On 2019-01-25 07:01, Thomas Huth wrote: >>> On 2019-01-24 18:23, Stefano Garzarella wrote: If the WRITE_ZEROES feature is enabled, we check this command in the test_basic(). >>

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-25 Thread Stefano Garzarella
On Fri, Jan 25, 2019 at 07:07:35AM +0100, Thomas Huth wrote: > On 2019-01-25 07:01, Thomas Huth wrote: > > On 2019-01-24 18:23, Stefano Garzarella wrote: > >> If the WRITE_ZEROES feature is enabled, we check this > >> command in the test_basic(). > >> > >> Signed-off-by: Stefano Garzarella > >> --

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-24 Thread Thomas Huth
On 2019-01-25 07:01, Thomas Huth wrote: > On 2019-01-24 18:23, Stefano Garzarella wrote: >> If the WRITE_ZEROES feature is enabled, we check this >> command in the test_basic(). >> >> Signed-off-by: Stefano Garzarella >> --- >> tests/virtio-blk-test.c | 63

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-24 Thread Thomas Huth
On 2019-01-25 07:01, Thomas Huth wrote: > On 2019-01-24 18:23, Stefano Garzarella wrote: >> If the WRITE_ZEROES feature is enabled, we check this >> command in the test_basic(). >> >> Signed-off-by: Stefano Garzarella >> --- >> tests/virtio-blk-test.c | 63

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-24 Thread Thomas Huth
On 2019-01-24 18:23, Stefano Garzarella wrote: > If the WRITE_ZEROES feature is enabled, we check this > command in the test_basic(). > > Signed-off-by: Stefano Garzarella > --- > tests/virtio-blk-test.c | 63 + > 1 file changed, 63 insertions(+) > > diff

[Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-24 Thread Stefano Garzarella
If the WRITE_ZEROES feature is enabled, we check this command in the test_basic(). Signed-off-by: Stefano Garzarella --- tests/virtio-blk-test.c | 63 + 1 file changed, 63 insertions(+) diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c index