On Tue, 12 May 2015 17:30:21 +0200
"Michael S. Tsirkin" wrote:
> On Tue, May 12, 2015 at 04:46:11PM +0200, Cornelia Huck wrote:
> > On Tue, 12 May 2015 15:44:46 +0200
> > Cornelia Huck wrote:
> >
> > > On Tue, 12 May 2015 15:34:47 +0200
> > > "Michael S. Tsirkin" wrote:
> > >
> > > > On Tue,
On Tue, May 12, 2015 at 04:46:11PM +0200, Cornelia Huck wrote:
> On Tue, 12 May 2015 15:44:46 +0200
> Cornelia Huck wrote:
>
> > On Tue, 12 May 2015 15:34:47 +0200
> > "Michael S. Tsirkin" wrote:
> >
> > > On Tue, May 12, 2015 at 03:14:53PM +0200, Cornelia Huck wrote:
> > > > On Wed, 06 May 201
On Tue, 12 May 2015 15:44:46 +0200
Cornelia Huck wrote:
> On Tue, 12 May 2015 15:34:47 +0200
> "Michael S. Tsirkin" wrote:
>
> > On Tue, May 12, 2015 at 03:14:53PM +0200, Cornelia Huck wrote:
> > > On Wed, 06 May 2015 14:07:37 +0200
> > > Greg Kurz wrote:
> > >
> > > > Unlike with add and cle
On 12 May 2015 at 14:14, Cornelia Huck wrote:
> On Wed, 06 May 2015 14:07:37 +0200
> Greg Kurz wrote:
>> @@ -233,7 +233,6 @@ static inline void virtio_clear_feature(uint32_t
>> *features, unsigned int fbit)
>>
>> static inline bool __virtio_has_feature(uint32_t features, unsigned int
>> fbit)
On Tue, 12 May 2015 15:14:53 +0200
Cornelia Huck wrote:
> On Wed, 06 May 2015 14:07:37 +0200
> Greg Kurz wrote:
>
> > Unlike with add and clear, there is no valid reason to abort when checking
> > for a feature. It makes more sense to return false (i.e. the feature bit
> > isn't set). This is ex
On Tue, 12 May 2015 15:34:47 +0200
"Michael S. Tsirkin" wrote:
> On Tue, May 12, 2015 at 03:14:53PM +0200, Cornelia Huck wrote:
> > On Wed, 06 May 2015 14:07:37 +0200
> > Greg Kurz wrote:
> >
> > > Unlike with add and clear, there is no valid reason to abort when checking
> > > for a feature. I
On Tue, May 12, 2015 at 03:14:53PM +0200, Cornelia Huck wrote:
> On Wed, 06 May 2015 14:07:37 +0200
> Greg Kurz wrote:
>
> > Unlike with add and clear, there is no valid reason to abort when checking
> > for a feature. It makes more sense to return false (i.e. the feature bit
> > isn't set). This
On Wed, 06 May 2015 14:07:37 +0200
Greg Kurz wrote:
> Unlike with add and clear, there is no valid reason to abort when checking
> for a feature. It makes more sense to return false (i.e. the feature bit
> isn't set). This is exactly what __virtio_has_feature() does if fbit >= 32.
>
> This allow
Unlike with add and clear, there is no valid reason to abort when checking
for a feature. It makes more sense to return false (i.e. the feature bit
isn't set). This is exactly what __virtio_has_feature() does if fbit >= 32.
This allows to introduce code that is aware about new 64-bit features like
