Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

2017-08-11 Thread Thomas Huth
On 11.08.2017 18:11, David Hildenbrand wrote: > On 11.08.2017 16:39, Thomas Huth wrote: >> On 11.08.2017 16:21, David Hildenbrand wrote: >>> On 11.08.2017 16:00, Thomas Huth wrote: On 11.08.2017 09:46, David Hildenbrand wrote: > cpu.h should only contain what really has to be accessed outs

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

2017-08-11 Thread David Hildenbrand
On 11.08.2017 16:39, Thomas Huth wrote: > On 11.08.2017 16:21, David Hildenbrand wrote: >> On 11.08.2017 16:00, Thomas Huth wrote: >>> On 11.08.2017 09:46, David Hildenbrand wrote: cpu.h should only contain what really has to be accessed outside of target/s390x/. Add internal.h which can

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

2017-08-11 Thread Thomas Huth
On 11.08.2017 16:21, David Hildenbrand wrote: > On 11.08.2017 16:00, Thomas Huth wrote: >> On 11.08.2017 09:46, David Hildenbrand wrote: >>> cpu.h should only contain what really has to be accessed outside of >>> target/s390x/. Add internal.h which can only be used inside target/s390x/. >>> >>> Mov

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

2017-08-11 Thread Thomas Huth
On 11.08.2017 09:46, David Hildenbrand wrote: > cpu.h should only contain what really has to be accessed outside of > target/s390x/. Add internal.h which can only be used inside target/s390x/. > > Move everything that isn't fast enough to run away and restructure it > right away. > > Minor style

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

2017-08-11 Thread David Hildenbrand
On 11.08.2017 16:00, Thomas Huth wrote: > On 11.08.2017 09:46, David Hildenbrand wrote: >> cpu.h should only contain what really has to be accessed outside of >> target/s390x/. Add internal.h which can only be used inside target/s390x/. >> >> Move everything that isn't fast enough to run away and r

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

2017-08-11 Thread David Hildenbrand
> By the way, all the other targets that have KVM have a separate header > for things like this: kvm_arm.h, kvm_ppc.h, kvm_mips.h, kvm_i386.h > ... maybe it's time for kvm_s390x.h now? Definitely! > > Thomas > -- Thanks, David

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

2017-08-11 Thread Thomas Huth
On 11.08.2017 09:46, David Hildenbrand wrote: > cpu.h should only contain what really has to be accessed outside of > target/s390x/. Add internal.h which can only be used inside target/s390x/. > > Move everything that isn't fast enough to run away and restructure it > right away. > > Minor style

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

2017-08-11 Thread David Hildenbrand
On 11.08.2017 15:15, Richard Henderson wrote: > On 08/11/2017 12:46 AM, David Hildenbrand wrote: >> + >> +static const char *cc_names[] = { >> +[CC_OP_CONST0]= "CC_OP_CONST0", > > This should get moved out of the header to the c file that uses it. > (Why it's ever there in the first place

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

2017-08-11 Thread Richard Henderson
On 08/11/2017 12:46 AM, David Hildenbrand wrote: > + > +static const char *cc_names[] = { > +[CC_OP_CONST0]= "CC_OP_CONST0", This should get moved out of the header to the c file that uses it. (Why it's ever there in the first place is a mystery...) Otherwise, Reviewed-by: Richard Hender

[Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

2017-08-11 Thread David Hildenbrand
cpu.h should only contain what really has to be accessed outside of target/s390x/. Add internal.h which can only be used inside target/s390x/. Move everything that isn't fast enough to run away and restructure it right away. Minor style fixes to avoid checkpatch warning to: - struct Lowcore: "{"