Re: [Qemu-devel] [PATCH RFC 04/16] hw/core/machine: Introduce pre_init

2016-07-14 Thread Andrew Jones
On Thu, Jul 14, 2016 at 05:10:47PM -0300, Eduardo Habkost wrote: > On Tue, Jun 14, 2016 at 07:58:56AM +0200, Andrew Jones wrote: > > On Tue, Jun 14, 2016 at 11:30:37AM +1000, David Gibson wrote: > > > On Fri, Jun 10, 2016 at 07:40:15PM +0200, Andrew Jones wrote: > > > > From: Igor Mammedov > > > >

Re: [Qemu-devel] [PATCH RFC 04/16] hw/core/machine: Introduce pre_init

2016-07-14 Thread Eduardo Habkost
On Tue, Jun 14, 2016 at 07:58:56AM +0200, Andrew Jones wrote: > On Tue, Jun 14, 2016 at 11:30:37AM +1000, David Gibson wrote: > > On Fri, Jun 10, 2016 at 07:40:15PM +0200, Andrew Jones wrote: > > > From: Igor Mammedov > > > > > > Signed-off-by: Igor Mammedov > > > Signed-off-by: Andrew Jones >

Re: [Qemu-devel] [PATCH RFC 04/16] hw/core/machine: Introduce pre_init

2016-06-13 Thread Andrew Jones
On Tue, Jun 14, 2016 at 11:30:37AM +1000, David Gibson wrote: > On Fri, Jun 10, 2016 at 07:40:15PM +0200, Andrew Jones wrote: > > From: Igor Mammedov > > > > Signed-off-by: Igor Mammedov > > Signed-off-by: Andrew Jones > > I think this needs some kind of rationale. > > Since with this patch i

Re: [Qemu-devel] [PATCH RFC 04/16] hw/core/machine: Introduce pre_init

2016-06-13 Thread David Gibson
On Fri, Jun 10, 2016 at 07:40:15PM +0200, Andrew Jones wrote: > From: Igor Mammedov > > Signed-off-by: Igor Mammedov > Signed-off-by: Andrew Jones I think this needs some kind of rationale. Since with this patch it is called immediately before ->init, I'm not really seeing the point of this.

[Qemu-devel] [PATCH RFC 04/16] hw/core/machine: Introduce pre_init

2016-06-10 Thread Andrew Jones
From: Igor Mammedov Signed-off-by: Igor Mammedov Signed-off-by: Andrew Jones --- hw/core/machine.c | 6 ++ include/hw/boards.h | 1 + vl.c| 1 + 3 files changed, 8 insertions(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index ccdd5fa3e7728..3dce9020e510a 100644