Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb

2015-11-27 Thread Paolo Bonzini
On 27/11/2015 13:39, Tim Sander wrote: > > I have one more thing, i2cdetect looks like this: > 0 1 2 3 4 5 6 7 8 9 a b c d e f > 00: 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f > 10: 10 11 12 13 14 15 16 17 18 19 1a 1b 1c 1d 1e 1f > 20: 20 21 22 23 24 25 26 27 28 29 2a

Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb

2015-11-27 Thread Tim Sander
Hi Paolo Am Freitag, 27. November 2015, 10:32:25 schrieb Paolo Bonzini: > On 26/11/2015 17:35, Tim Sander wrote: > > Below is a patch implementing the i2c-tiny-usb device. > > I am currently not sure about the i2c semantics. I think > > incrementing the address on longer reads is wrong? > > Yes,

Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb

2015-11-27 Thread Alex Bennée
Tim Sander writes: > Hi Alex > > Thanks for your feedback, answers as usual inline. > > Am Donnerstag, 26. November 2015, 18:07:35 schrieb Alex Bennée: >> Tim Sander writes: >> > Hi >> > >> You are missing a s-o-b line and scripts/checkpatch.pl complains about a >> few things you should fix be

Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb

2015-11-27 Thread Tim Sander
Am Freitag, 27. November 2015, 07:48:21 schrieb Gerd Hoffmann: > On Do, 2015-11-26 at 17:35 +0100, Tim Sander wrote: > > Hi > > > > Below is a patch implementing the i2c-tiny-usb device. > > Is there a specification for this kind of device? http://www.harbaum.org/till/i2c_tiny_usb/index.shtml > O

Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb

2015-11-27 Thread Markus Armbruster
Tim Sander writes: [...] >> I get that debug output is useful for debugging but if you want to >> maintain ability to look at the i2c transactions you might want to >> consider the tracing infrastructure. > Any pointers a quick search turned up the > http://wiki.qemu.org/Features/Tracing/Roadmap

Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb

2015-11-27 Thread Tim Sander
Hi Alex Thanks for your feedback, answers as usual inline. Am Donnerstag, 26. November 2015, 18:07:35 schrieb Alex Bennée: > Tim Sander writes: > > Hi > > > > Below is a patch implementing the i2c-tiny-usb device. > > I am currently not sure about the i2c semantics. I think > > incrementing the

Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb

2015-11-26 Thread Gerd Hoffmann
On Do, 2015-11-26 at 17:35 +0100, Tim Sander wrote: > Hi > > Below is a patch implementing the i2c-tiny-usb device. Is there a specification for this kind of device? Or does it mimic existing hardware? Please add that into to the comment at the head of the file. > +#ifdef DEBUG_USBI2C > +#defin

Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb

2015-11-26 Thread Alex Bennée
Tim Sander writes: > Hi > > Below is a patch implementing the i2c-tiny-usb device. > I am currently not sure about the i2c semantics. I think > incrementing the address on longer reads is wrong? > But at least i can read the high byte(?) of the temperature > via "i2cget -y 0 0x50". > > With this

[Qemu-devel] [PATCH RFC] i2c-tiny-usb

2015-11-26 Thread Tim Sander
Hi Below is a patch implementing the i2c-tiny-usb device. I am currently not sure about the i2c semantics. I think incrementing the address on longer reads is wrong? But at least i can read the high byte(?) of the temperature via "i2cget -y 0 0x50". With this device it should be possible to defi